Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

Edited by proposal-police: This proposal was edited at 2024-11-22 19:43:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Remove the task here

We should fix in the BE as well

What alternative solutions did you explore? (Optional)

Proposal Updated

• Minor update

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

What is the root cause of that problem?

Improvement needed

What changes do you think we should make in order to solve the problem?

1. "Enable your wallet" is already absent from the tasks of "Get paid back from my employer" onboarding menu. Nothing to do then
2. To remove "Add personal bank account" from the Chat and split expenses with friends onboarding tasks, we just need to remove here
   https://github.com/Expensify/App/blob/main/src/CONST.ts#L5102-L5116

no BE change needed

RESULT

What alternative solutions did you explore? (Optional)

None

@jjcoffee - can you please review these proposals so we can move forward?

I only see two tasks for Get paid back from my employer (on latest main), Submit an expense and Add personal bank account. There's no Take a 2-minute tour.

Could you confirm if we still need to make any changes to Get paid back from my employer? @anmurali or @danielrvidal

@jjcoffee Regarding Take a 2-minute tour we have some issues here: #52908 #52985

Thanks @NJ-2020! Looks like the fix has been CP'ed now, but there's still Add personal bank account instead of Enable your wallet.

I think you may have made a mistake in your proposal, with the third code block that needs updating (it repeats the first). Can you get that updated?

Assuming the above doesn't change anything regarding what we want to do here, I'm happy to go with @NJ-2020's proposal, as he was first and the general thrust is correct (even if the third code block to update isn't quite right 😉).

🎀👀🎀 C reviewed

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@jjcoffee Ohh, okay thank you, will update that on the PR

@jjcoffee @NJ-2020 mentionned a need to fix the BE, which is not also correct imho

Hi, regarding "Get paid back option" may I get the "Enable your wallet" task description please

cc: @danielrvidal @yuwenmemon

Why do you need the description for that if we're removing it? I'm not sure I understand. I think we're remove the task and description.

Ohh sorry about that, I though we need to replace the Add personal bank account with Enable your wallet based on this comment

@NJ-2020 No, I just meant that the current behaviour was a bit different from the issue description. We haven't agreed to do anything about it. You can proceed with the PR just dealing with removing the tasks as described in the issue.

For the recording videos, there's an issue the onboarding doesn't show up when login with new account

Should we wait until the issue got fix, or we can just override the nvp_onboarding value?

cc: @jjcoffee

@NJ-2020 Overriding nvp_onboarding is fine imo.

@danielrvidal, @yuwenmemon, @jjcoffee, @NJ-2020 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@jjcoffee Okay thanks

I will be OOO for 1 day

All good @NJ-2020 I'm guessing this should be pretty easy so do you think you can have a PR to review by EOD Wed?

PR ready

cc: @jjcoffee

This issue has not been updated in over 15 days. @danielrvidal, @yuwenmemon, @jjcoffee, @NJ-2020 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Reviewing the PR today!

Awesome, thank you!