Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page #52953

Open
8 tasks done
IuliiaHerets opened this issue Nov 22, 2024 · 27 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.65-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5250081
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • User has assigned themselves a virtual card.
  1. Go to staging.new.expensify.com
  2. Go to Wallet.
  3. Click on the card.
  4. Click Report virtual card fraud.
  5. Click Deactivate card.
  6. Enter magic code.

Expected Result:

After the card is deactivated in Wallet, it should be removed in Wallet.

Actual Result:

After the card is deactivated in Wallet, it reappears.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6672815_1732265618675.20241122_164451.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021861531007632186016
  • Upwork Job ID: 1861531007632186016
  • Last Price Increase: 2024-12-03
Issue OwnerCurrent Issue Owner: @fedirjh
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 26, 2024

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abekkala abekkala added the External Added to denote the issue can be worked on by a contributor label Nov 26, 2024
@melvin-bot melvin-bot bot changed the title Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page [$250] Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021861531007632186016

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 26, 2024
Copy link

melvin-bot bot commented Nov 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot removed the Overdue label Nov 26, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@abekkala, @fedirjh Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Dec 2, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Dec 2, 2024

Still looking for proposals

@ugogiordano
Copy link
Contributor

How a contributor outside US can reproduce this issue by adding a bank account and virtual card?

Copy link

melvin-bot bot commented Dec 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Dec 6, 2024

@abekkala @fedirjh this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Dec 6, 2024
Copy link

melvin-bot bot commented Dec 6, 2024

@abekkala, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot melvin-bot bot removed Help Wanted Apply this label when an issue is open to proposals by contributors Overdue labels Dec 9, 2024
@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Dec 9, 2024
@narefyev91
Copy link
Contributor

narefyev91 commented Dec 11, 2024

What findings:
Seems like after calling https://dev.new.expensify.com:8082/api/ReportVirtualExpensifyCardFraud?
In Onyx response we get - "newCardID": 21663305, and a new virtual card with exactly the same data:
Screenshot 2024-12-11 at 17 32 42
That's why technically user sees the same virtual card in the list. But generally it's a new one (with new ID) but with the same content.

The same flow in removing card directly inside workspace - is working fine:
https://dev.new.expensify.com:8082/api/Card_Deactivate?
Screenshot 2024-12-11 at 17 36 04

@muttmuure we need some from BE side to check - why we get a new card aflter ReportVirtualExpensifyCardFraud is executed
cc @fedirjh

@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Dec 12, 2024

@abekkala Can you please add the internal label based on this #52953 (comment) ? Thanks.

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2024
@abekkala abekkala added the Internal Requires API changes or must be handled by Expensify staff label Dec 13, 2024
@abekkala
Copy link
Contributor

Oh yeah, internal doesn't auto assign an engineer

@abekkala abekkala added AutoAssignerNewDotQuality Used to assign quality issues to engineers and removed Internal Requires API changes or must be handled by Expensify staff labels Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @lakchote (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 13, 2024
@abekkala abekkala removed the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Dec 13, 2024
@abekkala
Copy link
Contributor

@lakchote
COMMENT FROM ABOVE

we need someone from BE side to check - why we get a new card aflter ReportVirtualExpensifyCardFraud is executed

@lakchote
Copy link
Contributor

we need some from BE side to check - why we get a new card aflter ReportVirtualExpensifyCardFraud is executed

We create a replacement card after ReportVirtualExpensifyCardFraud is executed because the card reported has been deactivated.

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
@fedirjh
Copy link
Contributor

fedirjh commented Dec 16, 2024

@lakchote, So it's expected that the card is not removed when deactivated?

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2024
@lakchote
Copy link
Contributor

@lakchote, So it's expected that the card is not removed when deactivated?

What is expected is to have the card being replaced with the same values if it's an admin issued virtual card.

That's what happened in the logs:
image

So I'm not sure this issue is actually relevant?

cc @MariaHCD since you've authored the code relevant to the replacement

@melvin-bot melvin-bot bot added the Overdue label Dec 19, 2024
@MariaHCD
Copy link
Contributor

When a user reports fraud or that their virtual card is stolen, we deactivate the current one and re-issue a new one in its place. The new card will have the same configuration as the deactivated card such as card title, limit, etc. The card numbers will be different for the new card, however.

So it seems like we need to make it more in the UI/UX that a new card has been issued

Copy link

melvin-bot bot commented Dec 20, 2024

@abekkala @lakchote @narefyev91 @fedirjh this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

Copy link

melvin-bot bot commented Dec 20, 2024

@abekkala, @lakchote, @narefyev91, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 24, 2024

@abekkala, @lakchote, @narefyev91, @fedirjh 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@fedirjh
Copy link
Contributor

fedirjh commented Dec 25, 2024

So it seems like we need to make it more in the UI/UX that a new card has been issued

@MariaHCD Should we update the UI and add a little badge new to the newly created card ?

cc @Expensify/design

@melvin-bot melvin-bot bot removed the Overdue label Dec 25, 2024
@shawnborton
Copy link
Contributor

Just to make sure I am understanding correctly...

It seems like on this screen here, after you report fraud, we should probably have some kind of message on the card details view that lets you know the card was deactivated?
CleanShot 2024-12-26 at 14 12 43@2x

Or what exactly is the flow that should be happening once you report fraud? Do we automatically reissue a new card?

@fedirjh
Copy link
Contributor

fedirjh commented Dec 26, 2024

we should probably have some kind of message on the card details view that lets you know the card was deactivated?

@shawnborton We have this message . Then we automatically reissue a new card.

Screenshot 2024-12-26 at 9 15 30 PM

@shawnborton
Copy link
Contributor

If we automatically reissue a new card, why do we show a blank page like this:
image

Instead of just repopulating the page with the new details like this:
CleanShot 2024-12-27 at 11 10 27@2x

I'm not too familiar with the card flows though so perhaps I am not understanding correctly. cc @MariaHCD @joekaufmanexpensify for more thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: CRITICAL
Development

No branches or pull requests

8 participants