Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Settlement account is blank when second admin accesses the page

What is the root cause of that problem?

Currently on the expensify cards settings page, we get the current users personal bank account details:

Hence we do not see current bank selected.

But here we need the current policy account details and not individual, hence from admin account the field is shown as blank.

What changes do you think we should make in order to solve the problem?

To fix it, firstly we should get the bank account data from policy?.achAccount and then display that in the settings page:

1. So in WorkspaceCardSettingsPage:
   

   App/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx

   Line 25 in 51e25af

   function WorkspaceCardSettingsPage({route}: WorkspaceCardSettingsPageProps) {

   
   

   App/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx

   Line 38 in 51e25af

   const bankAccountNumber = bankAccountList?.[paymentBankAccountID.toString()]?.accountData?.accountNumber ?? '';

We need to get the achAccount data and get the bank account number from there:

const bankAccountNumber = policy?.achAccount?.accountNumber ?? '';

2. Then in WorkspaceSettlementAccountPage, we have multiple options.

a) Either disable this page for admins, This is because now we will get the admin's bank accounts rather than the owners.
b) If we want to allow the settlement accounts to be changed to the admins bank account then the current implementation works, but with a catch that if there is no bank account added by the admin then we should show an empty RHP stating that please add a bank account.

I think option A is more appropriate here given that we do not want the admin to add their own bank account

What alternative solutions did you explore? (Optional)

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Job added to Upwork: https://www.upwork.com/jobs/~021861520764980845600

Opening up to the community

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

@JmillsExpensify, @eh2077 Huh... This is 4 days overdue. Who can take care of this?

@eh2077 can you please review my proposal here

@twilight2294 I have trouble to setup Expensify Card. Can you share steps to setup Expensify Card?

Connect this bank account and then assign expensify cards from workspace. that's all i did to reproduce this issue

I managed to reproduce the bug.

@twilight2294 's proposal looks good to me. Let's go with their proposal!

🎀👀🎀 C reviewed

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@eh2077 Sorry, I am not sure that policy?.achAccount is existing

Coincidentally I'm also following this because it's part of the Expensify Card feature which I've been in charge of since the beginning.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

achAccount

@DylanDylann don't worry i have checked thoroughly it exists below:

We already use a similar check here:

My solutions solves this bug efficiently , @Beamanator can you assign me here please as per summary by C . Also if you have any doubts then let me know, i can answer then

Started a thread here

@twilight2294 we need to discuss this internally first to know the right expectations

Thank you for taking over, kind sir @mountiny 🙏

@DylanDylann Would you like take over this as C as you have more context about the feature? Thanks 🙏

@eh2077 IMO, this issue may need to be fixed on the BE side, I can help to take over it and follow the discussion

@twilight2294 we need to discuss this internally first to know the right expectations

Okay, I will update the proposal when the expected result is updated, thanks

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

We decided to fix this issue on the BE here. When it is done, I will retest this issue

@JmillsExpensify @mountiny @DylanDylann this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Issue not reproducible during KI retests. (First week)

This is internal but not as high priority so making weekly

@JmillsExpensify, @mountiny, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

Havent started on the BE fix

No updates