Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OldDot's default output currency setting to NewDot #52769

Open
JmillsExpensify opened this issue Nov 19, 2024 · 17 comments
Open

Add OldDot's default output currency setting to NewDot #52769

JmillsExpensify opened this issue Nov 19, 2024 · 17 comments
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Overdue

Comments

@JmillsExpensify
Copy link

Problem
NewDot trial users have consistently run into an issue where they sign up in a certain country – for instance, Spain and EUR – but their employer uses a different currency and expects all reports to be submitted in that same currency. This not only creates confusion, but it's detrimental to our bottom-up conversation overall.

Solution
For consistency with OldDot and to increase our changes that bottom-up flows work without a hitch, let's add a Payment currency setting to NewDot. This is equivalent to the Report Currency setting in OldDot's personal type policy, and functions exactly the same – meaningly, this sets the currency all expenses on a report should be converted to.

In NewDot the setting will look like this.
image

@JmillsExpensify JmillsExpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Nov 19, 2024
@JmillsExpensify JmillsExpensify self-assigned this Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 19, 2024
@JmillsExpensify
Copy link
Author

@jamesdeanexpensify any feedback on the text on either of these screens?

Keeping internal until we align on the solution.

@jamesdeanexpensify
Copy link
Contributor

Thoughts on:

Select your currency for paying and getting paid back by friends.

@JmillsExpensify
Copy link
Author

Going to think on this one a little more. It's a bit tricky.

@mkzie2
Copy link
Contributor

mkzie2 commented Nov 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add OldDot's default output currency setting to NewDot

What is the root cause of that problem?

New feature

What changes do you think we should make in order to solve the problem?

  1. Add the payment currency item after the language item here. To get the current currency we can use getPersonalPolicy to get the personal policy and getting the currency from outputCurrency field. When clicking on this item we will navigate to the edit payment currency page
<MenuItemWithTopDescription
    shouldShowRightIcon
    title={`${paymentCurrency} - ${getCurrencySymbol(paymentCurrency)}`}
    description={translate('billingCurrency.paymentCurrency')}
    onPress={() => Navigation.navigate(ROUTES.SETTINGS_PAYMENT_CURRENCY)}
    wrapperStyle={styles.sectionMenuItemTopDescription}
/>
  1. Create a PaymentCurrencyPage which is the page to edit the currency
  • To display the currency list we can use CurrencySelectionList
  • After selecting a currency, go back to the preference page
  • To update the currency we can call updateGeneralSettings with policyID as the personal policyID

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-11-21.at.17.18.15.mov

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Nov 21, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@JmillsExpensify
Copy link
Author

Still in planning

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 26, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

@JmillsExpensify Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Dec 4, 2024

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

@JmillsExpensify
Copy link
Author

still in the queue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 4, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

@JmillsExpensify
Copy link
Author

Same as above

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 11, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 18, 2024

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

@JmillsExpensify
Copy link
Author

Still not a priority

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 18, 2024
Copy link

melvin-bot bot commented Dec 24, 2024

@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Dec 26, 2024

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Overdue
Projects
Status: No status
Development

No branches or pull requests

3 participants