Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

This behavior is expected, as we do not show the local time zone until the user has been validated. This was implemented here to address a significant privacy concern. To resolve this issue, we can remove the isParticipantValidated check from here.

Edited by proposal-police: This proposal was edited at 2024-11-13 20:41:41 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unvalidated user cannot see his own local timezone in self-DM

What is the root cause of that problem?

Here as seen in the video, the current user should be able to see his own timezone in his own selfDM, currently we use the following check to show timezone:

This case is partially correct, we only want to show timezone on profile page of any user only when the participant is validated, but for self-DM as the participant is the current user itself, we should show the timezone in case of self dm

What changes do you think we should make in order to solve the problem?

Update the check to:

    const isSelfDM = ReportUtils.isSelfDM(report)
    const shouldShowLocalTime = !ReportUtils.hasAutomatedExpensifyAccountIDs([accountID]) && !isEmptyObject(timezone) && (isParticipantValidated || isSelfDM);

What alternative solutions did you explore? (Optional)

@strepanier03 , note that the bug here is that there is no timezone displayed if the user visits his own profile from self-DM

Job added to Upwork: https://www.upwork.com/jobs/~021858726442470926380

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

Upwork job price has been updated to $150

@strepanier03 I don’t think this is a bug. We hide the timezone for unvalidated users intentionally, as shown in the attached PR. Even for self-DMs, we shouldn’t display the timezone for invalidated users since they can log in with random numbers and view the timezone from their self-DM.

This was a major bug which showed timezones even for unvalidated accounts, this was a big privacy issue which is addressed in the PR

Prerequisite
Log in with Gmail account and changes time zone (Must be Gmail account)

Steps:

1. As another user (or from another device) navigate to the conversation with the main user (where all changes were made)
2. Click on the header of the conversation
3. Verify the user details page display local time of the user

@IuliiaHerets Is the main user account (where all changes were made) validated? If not, the time zone is not expected to display.

cc: @strepanier03

If not, the time zone is not expected to display.

This is true for other user profiles right @sobitneupane ? for self-profile, user can view their own timezone without any issue

@strepanier03, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

@strepanier03, I believe this is not a bug but an intentional choice, as the user account is yet to be validated.

for self-profile, user can view their own timezone without any issue

@twilight2294 don't think it matters much whether we show or hide the timezone for the self-profile.

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03 @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@strepanier03, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

@strepanier03 #52470 (comment)

don't think it matters much whether we show or hide the timezone for the self-profile.

We show timezone on the profile page, so is there a reason to not show them on their own self dm?:

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Issue not reproducible during KI retests. (First week)

@strepanier03, @sobitneupane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03 @sobitneupane this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

We show timezone on the profile page, so is there a reason to not show them on their own self dm?:

I don't think it's worth adding the timezone only for self-DMs of unauthorized users. It's better to keep it consistent across all chats.

I don't think it's worth adding the timezone only for self-DMs of unauthorized users. It's better to keep it consistent across all chats.

Umm, i will leave it to @strepanier03 whether we should fix the bug or not, okay both ways 😄

@strepanier03, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03, @sobitneupane 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@strepanier03 #52470 (comment) Good To Close

Issue not reproducible during KI retests. (Second week)

@strepanier03, @sobitneupane Whoops! This issue is 2 days overdue. Let's get this updated quick!

#52470 (comment)

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@strepanier03, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!