Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@strepanier03 Eep! 4 days overdue now. Issues have feelings too...

I was able to reproduce this and have tied it to a project. Setting external now.

Job added to Upwork: https://www.upwork.com/jobs/~021858724639436105772

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Edited by proposal-police: This proposal was edited at 2024-11-19 08:36:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Description hint field shows previous data after reenabling "Require description"

What is the root cause of that problem?

When we toggle Require description to disable, we set commentHint to '', which is updated in Onyx to ''. That why, we can see Description hint was remove.

However, on the server, we do not update commentHint to ''. I say this because when we close the RHP and open it again, the OpenPolicyCategoriesPage is still able to retrieve the current value of commentHint.

What changes do you think we should make in order to solve the problem?

To resolve this issue, we must remove the description hint when we toggle Require description to disable, something like this:

//src/pages/workspace/categories/CategorySettingsPage.tsx#L245
         <Switch
            isOn={policyCategory?.areCommentsRequired ?? false}
            accessibilityLabel={translate('workspace.rules.categoryRules.requireDescription')}
             onToggle={(isOn) => {
                 if (policyCategory.commentHint && !isOn) {
                     Category.setWorkspaceCategoryDescriptionHint(policyID, categoryName, '');
                 }
                Category.setPolicyCategoryDescriptionRequired(policyID, categoryName, !areCommentsRequired);
            }}
        />

Test branch

What alternative solutions did you explore? (Optional)

Or we can use areCommentsRequired to check when setting the workspace description hint

//src/pages/workspace/categories/CategorySettingsPage.tsx#L245
         <Switch
            isOn={policyCategory?.areCommentsRequired ?? false}
            accessibilityLabel={translate('workspace.rules.categoryRules.requireDescription')}
            onToggle={() => {
                 if (policyCategory.commentHint && areCommentsRequired) {
                     Category.setWorkspaceCategoryDescriptionHint(policyID, categoryName, '');
                 }
                Category.setPolicyCategoryDescriptionRequired(policyID, categoryName, !areCommentsRequired);
            }}
        />

I believe it is better to be fixed at backend where we just have to update the API. If we don't want to update the backend then @huult's proposal looks good to me.

🎀 👀 🎀 C reviewed

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@strepanier03 @lakchote @parasharrajat this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@strepanier03, @lakchote, @parasharrajat Huh... This is 4 days overdue. Who can take care of this?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Bump @lakchote

Sorry @parasharrajat for the late answer.

I like @huult's proposal, which makes the API call to set it correctly.

@huult's proposal LGTM.

❌ There was an error making the offer to @huult for the Contributor role. The BZ member will need to manually hire the contributor.

@strepanier03 could you please make an offer to @huult? Thanks!

Here is my Upwork profile:

https://www.upwork.com/freelancers/~0177bfe6ca1fe859f7

@parasharrajat PR is ready for review.

@strepanier03 Waiting for you to make an offer for me. Thank you!

friendly bump @strepanier03 per #52399 (comment)

@lakchote @strepanier03 I still haven’t received an offer on Upwork. Can you check it? Thank you!

Just a heads up the automation for payment will make a job, or the BZ makes one when payment is due if there isn't an automatic one made.. I'll make one now since it seems like work isn't moving forward until it comes.

Offer sent, payment is still on hold.

Thank you! I received an offer

This issue has not been updated in over 15 days. @strepanier03, @huult, @lakchote, @parasharrajat eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

PR is ready for final review.

@lakchote Could you check this pull request #53249 when you have time? thank you