Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@abekkala Huh... This is 4 days overdue. Who can take care of this?

@abekkala 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Job added to Upwork: https://www.upwork.com/jobs/~021857151760601711832

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

confirmed the composer should not be partially hidden by the header

@abekkala, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Waiting for proposal

@abekkala @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@abekkala, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@abekkala, @thesahindia Still overdue 6 days?! Let's take care of this!

Edited by proposal-police: This proposal was edited at 2024-11-28 16:03:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The mWeb/Chrome Chat Edition composer is cut off when editing a multiline message near the top of the screen.

What is the root cause of that problem?

The scroll pushed by soft input keyboard and in some cases it will cut the editor.

What changes do you think we should make in order to solve the problem?

I think we need to scroll to the edited report action before we perform editing. This way we can ensure that the edited message is near the top of the soft input keyboard

In src/pages/home/report/ReportActionItem.tsx modify this use effect to add scrollToIndex

    useEffect(() => {
        if (prevDraftMessage !== undefined || draftMessage === undefined) {
            return;
        }

        InteractionManager.runAfterInteractions(() => {
            requestAnimationFrame(() => {
                reportScrollManager.scrollToIndex(index);
            });
        })

        focusComposerWithDelay(textInputRef.current)(true);
    }, [prevDraftMessage, draftMessage]);

Optional:
Limit to Browser.isMobileChrome or Browser.isMobile or canUseTouchScreen if we don't want this behavior on other platforms

• We might need to disable animate for more responsive result

in useReportScrollManager make animated as param with default to true

    /**
     * Scroll to the provided index. On non-native implementations we do not want to scroll when we are scrolling because
     */
    const scrollToIndex = useCallback(
        (index: number, isEditing?: boolean, animated: boolean = true) => {
            if (!flatListRef?.current || isEditing) {
                return;
            }
    
            flatListRef.current.scrollToIndex({index, animated});
        },
        [flatListRef],
    );

And use false value in the use effect

    useEffect(() => {
        if (prevDraftMessage !== undefined || draftMessage === undefined) {
            return;
        }

        InteractionManager.runAfterInteractions(() => {
            requestAnimationFrame(() => {
                reportScrollManager.scrollToIndex(index, false, false);
            });
        })

        focusComposerWithDelay(textInputRef.current)(true);
    }, [prevDraftMessage, draftMessage]);

Branch for this solution

What alternative solutions did you explore? (Optional)

We can modify ReportActionItemMessageEdit to also scroll the reportActionItem for mWeb

src/pages/home/report/ReportActionItemMessageEdit.tsx

                            onFocus={() => {
                                setIsFocused(true);
                                if (textInputRef.current) {
                                    ReportActionComposeFocusManager.editComposerRef.current = textInputRef.current;
                                }
                               const shouldScrollOnEdit = canUseTouchScreen() ? isFocused && prevIsFocused === isFocused : true;
                                InteractionManager.runAfterInteractions(() => {
                                    requestAnimationFrame(() => {
                                        reportScrollManager.scrollToIndex(index, shouldScrollOnEdit );
                                    });
                                });

The shouldScrollOnEdit can be one of these:

canUseTouchScreen can be altered with isSmallScreen / Browser.isMobile / Browser.isMobileChrome

Proposal Updated

• Add branch link

@abekkala, @thesahindia 10 days overdue. Is anyone even seeing these? Hello?

@thesahindia can you take a look at the updated proposal from @wildan-m

I couldn’t get to it today. I’ll review it first thing when I get to work.

@wildan-m, it doesn't look good.

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@abekkala
Could you please go back Help Wanted label ?😅

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Not overdue
Waiting for proposals

@abekkala, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

waiting for proposals

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Not overdue
Waiting for proposals

Not overdue
Still waiting for proposals

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@abekkala, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

Not overdue
Waiting for proposals

@abekkala
Maybe we should adjust the bounty to motivate more people ? 😃

@abekkala, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

Not overdue

I'll check with CS and SWM after the new year

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸