Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoices - Unable to update company name and website #51871

Closed
8 tasks done
lanitochka17 opened this issue Nov 1, 2024 · 15 comments
Closed
8 tasks done

Invoices - Unable to update company name and website #51871

lanitochka17 opened this issue Nov 1, 2024 · 15 comments
Assignees
@madmax330
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Nov 1, 2024 •
edited
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.56-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace
  3. Go to workspace settings
  4. Enable Invoices
  5. Go to Invoices
  6. Add company name and company website
  7. Click on the company name
  8. Edit the existing company name and save it
  9. Repeat Step 7 and 8 for company website

Expected Result:

User should be able to update company name and website

Actual Result:

User is unable to update company name and website
The company name and website cannot be updated once the initial info is entered

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6652248_1730464000115.20241101_201955.mp4

View all open jobs on GitHub
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Nov 1, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 1, 2024

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 1, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-bills

@github-actions github-actions bot mentioned this issue Nov 1, 2024
Closed
@tgolen
Copy link
Contributor

tgolen commented Nov 1, 2024

It sounds like this is directly related to #50571. @rezkiy37 Could you please look into this ASAP?

@melvin-bot melvin-bot bot mentioned this issue Nov 1, 2024
Closed
@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
@Beamanator
Copy link
Contributor

Bumped in the blocker slack thread

@Julesssss
Copy link
Contributor

Downgrading this from being a blocker. This API was just added as a new feature and only breaks on the second use.

@github-actions github-actions bot mentioned this issue Nov 4, 2024
Closed
63 tasks
@tgolen tgolen added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@tgolen tgolen assigned madmax330 and unassigned tgolen Nov 4, 2024
@tgolen
Copy link
Contributor

tgolen commented Nov 4, 2024

Sounds like @madmax330 will be looking into this more with a backend fix (Slack ref)

@tgolen tgolen mentioned this issue Nov 4, 2024
Merged
50 tasks
@rezkiy37
Copy link
Contributor

rezkiy37 commented Nov 5, 2024

That"s definitely a backend bug. Moreover, I could not reproduce it with legacy workspaces but only with newly created ones.

Error: "400 invoice attribute is missing or malformed"

Details

Bug.mp4

@rezkiy37 rezkiy37 mentioned this issue Nov 5, 2024
Closed
8 tasks
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@madmax330
Copy link
Contributor

Pr is up

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@madmax330 madmax330 added the Reviewing Has a PR in review label Nov 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Nov 19, 2024

@madmax330 Whoops! This issue is 2 days overdue. Let"s get this updated quick!

@madmax330
Copy link
Contributor

This should be fixed now

@madmax330 madmax330 reopened this Nov 19, 2024
@madmax330
Copy link
Contributor

@rezkiy37 can you double check?

@rezkiy37
Copy link
Contributor

The bug has been fixed. It works properly with legacy and newly created workspaces.

Video

No.bug.mp4

cc @madmax330

@madmax330
Copy link
Contributor

Cool, let"s close this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madmax330 madmax330

Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tgolen @Beamanator @madmax330 @Julesssss @rezkiy37 @lanitochka17