-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-18] [Workspace feeds] Company Cards - Bank name persists between different banks in the Other card feed #51860
Comments
Triggered auto assignment to @JmillsExpensify ( |
Triggered auto assignment to @tylerkaraszewski ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #wave-collect - Release 2 |
Edited by proposal-police: This proposal was edited at 2024-11-01 15:22:42 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Bank name persists between different banks in the Other card feed. What is the root cause of that problem?After we click next the bank name is saved then we are setting the default value of the bank name here
What changes do you think we should make in order to solve the problem?We should reset the value of the bank name when navigating back.
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Bank name persists between different banks in the Other card feed What is the root cause of that problem?When the user enters the name of the card, it is stored in Onyx.
However, when we go back and select another card type, only the feedType is changed, while the name remains unchanged.App/src/pages/workspace/companyCards/addNew/CardTypeStep.tsx Lines 100 to 104 in bfce277
What changes do you think we should make in order to solve the problem?We should also reset the name when the user selects a different card type. By implementing this, we preserve the name if the user selects the same card type while ensuring that the name is set to null if a different card type is chosen.
App/src/pages/workspace/companyCards/addNew/CardTypeStep.tsx Lines 100 to 104 in bfce277
What alternative solutions did you explore? (Optional) |
Thanks for the proposals so far, can anyone confirm which PR caused this regression? |
Downgrading from blocker -- users can simply delete the name manually for now. |
Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-18. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist:
Bug classificationSource of bug:
Where bug was reported:
Who reported the bug:
Regression Test ProposalPrecondition:
Test:
Verify that bank name field is empty Do we agree 👍 or 👎 |
Payment Summary
BugZero Checklist (@JmillsExpensify)
|
Should we add a regression test for this? @JmillsExpensify if not, we can close this as payments will be handled in lumpsum |
I think we should add a regression test for this one. |
@JmillsExpensify there is one proposed from @allgandalf so I think we can go ahead with that one |
Ah haha sorry I missed it in the scroll. I'll add. |
@allgandalf are you being paid a lump sum for this project? |
Yes yes, no payment here @JmillsExpensify 🙇 |
Awesome thanks! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.56-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #51569
Action Performed:
Expected Result:
Bank name should be cleared when choosing a different bank
Actual Result:
Bank name persists between different banks in the "Other" card feed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6651888_1730441823181.MGTM7335.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @JmillsExpensifyThe text was updated successfully, but these errors were encountered: