Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

1:1 Submit expense - Scan failure should not ask receiver to enter information

What is the root cause of that problem?

We are displaying the same Enter an amount text for both side of the users

What changes do you think we should make in order to solve the problem?

We should display this copy only if the user canEditAmount and add another appropriate copy (like No amount set yet) and display it when the user can't modify the amount

                    translationPath: canEditAmount ? 'common.error.enterAmount' : 'common.error.noAmount',

We should do the same enterDate and enterMerchant

What alternative solutions did you explore? (Optional)

Optionally we can also avoid displaying the error for the receiving end

Adding to my testing list, I'll review this one soon.

No update yet

Job added to Upwork: https://www.upwork.com/jobs/~021854642765194540226

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@getusha - can you please confirm if this proposal will fix this issue?

Heads up, I will be offline until Tuesday, November 12, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If it can wait, I'll continue the review process when I return online. Thanks!

@alexpensify The title of the issue should be updated according to the expected result

Expected Result:
The receiving end of the IOU should not be asked to fill out information if the scan failed

Done! Thanks for the feedback.

@alexpensify @getusha this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@alexpensify, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@getusha any update regarding the review here? Thanks!

@alexpensify, @getusha Huh... This is 4 days overdue. Who can take care of this?

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@FitseTLT we agreed on showing a system message instead of an error on the input, for this issue we just need to remove the error and RBR for the non-editable side.

@mountiny should we show $0.00 instead of leaving the field empty?

With the RBR I think in addition to the RBR shown in transaction details view, we should also remove the one displayed in LHN and ReportPreview and also MoneyRequestPreview for the non-editable side. Otherwise, we will be leading the user with the RBR into transaction details view where there won't be any violation RBR displayed which would be confusing.
@getusha BTW there are similar problems regarding other violations for other fields as well (like Missing Tag) which would extend the scope of this issue so should we handle only the amount and merchant case here?

Correct, for the user who cannot edit the expense, they should not see the RBR anywhere

which would extend the scope of this issue so should we handle only the amount and merchant case here?

Yeah I assume this applies for any violation, the fix should cover a generic case of not showing the RBR when the user cannot edit the expense

@alexpensify, @mountiny, @FitseTLT, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@getusha @FitseTLT How is this looking?

PR will be ready tomorrow 👍

@mountiny I have been working on removing RBR from the non-editable side but the problem is RBR is shown on a different level such as workspace chat, money report, report preview, and money request preview. So let's say the violation/error is related to the amount field to determine whether the current user can edit amount field of a transaction we need to have the parentReportAction and transactionThreadReport linked to the transaction

@FitseTLT I see what you mean about not all data being accessible. So what we can do is to change the text for the admin, but they will still see the RBR leading you to something they cannot edit if they just signed in, is that right?

@FitseTLT I see what you mean about not all data being accessible. So what we can do is to change the text for the admin, but they will still see the RBR leading you to something they cannot edit if they just signed in, is that right?

Yes

@alexpensify, @mountiny, @FitseTLT, @getusha 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@mountiny bump on the ^

I think that is ok edge case to have for now, I believe we will stop sending the expense reports without RBR to the user from the backend

So lets just hide the text

I think that is ok edge case to have for now, I believe we will stop sending the expense reports without RBR to the user from the backend

So lets just hide the text

@mountiny To summarize:
RBRs on workspace chats, report previews, money request view will show for non-editable side (b/c we can't reliably determine whether it is editable or not due to lack of data) and when the user opens the expense details page we will only have RBR icons on the fields but not text beside it ?? I mean, IMO, what would be ideal is change the Enter amount text to something like Amount is not Entered for the non-editable side instead of only show red icon which might be confusing

No, once they open the thread, the RBR will be gone, as we will have enough data.

Users are not expected to keep signing out so this is an edge case for only fresh sign ins, if you use the app you get all the data through pusher and RBR should not show up

Working on this. Will make PR ready by EOW 👍

@alexpensify, @mountiny, @FitseTLT, @getusha 10 days overdue. Is anyone even seeing these? Hello?

Ok, thank you for the update.

@FitseTLT do you have a PR update? Thanks!

@FitseTLT do you have a PR update? Thanks!

Done with the code will record screenshots and create the PR tomorrow. Thx for your patience

Heads up, I will be offline until Wednesday, December 18, 2024, and will not actively watch over this GitHub during that period.

If this GitHub requires an urgent update, please ask for help in the #expensify-open-source Slack Room. If the inquiry can wait, I'll review it when I return online.

Weekly Update: PR is moving along through the review process