Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 1

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-10-21 09:46:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

xpense - Expense fields are editable after the workspace is deleted

What is the root cause of that problem?

Inside canEditFieldOfMoneyRequest we don't check if the workspace is archived

What changes do you think we should make in order to solve the problem?

We need to check if the report is archived

if (isArchivedRoom(report)) {
    return false;
}

Note: We need some changes on the BE side to return correct private_isArchived value

What alternative solutions did you explore? (Optional)

#50352 (comment)
This was my Proposal for exactly similar issue, and I suggested a complete solution where we might be able to completely solve this GH and any similar future issues we might face rather then simple situation based temporary solution.

This might be expected as open expense requests are not archived when the workspace is archived. Tagging @trjExpensify for context.

The workspace being deleted doesn't mean you can't edit the details of the expenses on the expense report if it's in a state you could edit them prior to deletion. What you shouldn't be able to do is 1) add new expenses to it or 2) submit, approve or pay it. Those restrictions/action buttons are being worked on in another issue though.

Closing as expected behavior

The workspace being deleted doesn't mean you can't edit the details of the expenses on the expense report if it's in a state you could edit them prior to deletion. What you shouldn't be able to do is 1) add new expenses to it or 2) submit, approve or pay it. Those restrictions/action buttons are being worked on in another issue though.

What is the purpose of allowing editing the expense in an archived workspace? There is a new related issue here: #52896 where the backend doesn't update correctly an expense that belongs to an archived room.

I'm just asking because it may be easier to prevent this in the frontend. Is it a real user case that someone may want to edit an expense in an archived workspace?

What is the purpose of allowing editing the expense in an archived workspace?

Backwards compatibility with OldDot at this juncture, mainly. Expense reports don't change state when a policy is deleted (i.e gets moved to "closed"). We don't prevent editing expense details on the expense reports outside of the usual report state restrictions, nor prevent commenting on them, nor most actions really. We do prevent onward actions on the policy like approve/pay, and give you the ability to move the expense report to another workspace to continue those. The latter of which we're hoping to bring to NewDot soon as well.

I see, thanks! then the expected behaviour in #52896 is correct in expecting the backend to do the modification correctly 🙇