Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #vip-bills

@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-10-21 10:04:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The workspace avatar at the top of the report disappears then reappears after the workspace is deleted.
The workspace avatar of the invoice preview changes to a different avatar and then back to the original avatar.

What is the root cause of that problem?

There're 2 problems:

1. Invoices - Workspace avatar changes briefly after invoice receiver deletes workspace

After deleting the WS, BE will update it to null in Onyx

When users go to invoice chat, we need to get the avatar of that policy in

but it's just available when OpenReport API returns that policy data so we can see the blink problem

2. Users delete WS in offline mode, we can see the duplicate WS image

After deleting the WS, we update the policyName is empty and oldPolicy is deletedWS in

So the first icon is deleted WS avatar (getPolicyName returns report.oldPolicyName)

And the second one is receiverPolicy avatar that has the same name with deleted WS

If users go online again, BE will return the correct policyName and oldPolicyName

What changes do you think we should make in order to solve the problem?

1. We should update BE to return the default WS same as what OpenReport API returns, and update the optimistic data for deleted WS in this case if needed

2. We shouldn't set policyName to empty if it's invoice report in here same as what OpenReport API returns

reportsToArchive.forEach((report) => {
        let isInvoiceReport = false;
        if(report?.invoiceReceiver?.policyID === policyID){
            isInvoiceReport = true
        }

        ...
                stateNum: CONST.REPORT.STATE_NUM.APPROVED,
                statusNum: CONST.REPORT.STATUS_NUM.CLOSED,
                private_isArchived: currentTime,
                ...(isInvoiceReport ? {}: {
                    policyName: '',
                    oldPolicyName: allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`]?.name ?? '',
                })
            },
        });

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~021848544462980755973

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@daledah there's still bug (check above video around 38s after making online from offline) after applying your solution which fixes Users delete WS in offline mode, we can see the duplicate WS image. Can we also fix that?

And I am not able to reproduce the first bug - Invoices - Workspace avatar changes briefly after invoice receiver deletes workspace

@aimane-chnaif You mean the avatar order, right?

@aimane-chnaif You mean the avatar order, right?

right. and order of workspace names as well

@aimane-chnaif We have the logic to reverse the icons here

It's added on purpose. Do you think we need to fix it?

@daledah another question:

We shouldn't set policyName to empty if it's invoice report

If it's not invoice report, why can't we remove setting policyName?

@aimane-chnaif It's added in #38376 and the author want to reset it to match with BE's result #37759 (comment)

I think Invoice report and other one have the different behavior

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

And I am not able to reproduce the first bug - Invoices - Workspace avatar changes briefly after invoice receiver deletes workspace

@daledah can you?

Yes, I still can reproduce @aimane-chnaif

@daledah's proposal looks good to me.
🎀👀🎀 C reviewed

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@cead22 @johncschuster @aimane-chnaif this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@cead22 Yes, I suppose so. I'll add the optimistic and failure data for deleteWorkspace in the PR as well.
Actually we don't need to change anything, optimistic data is correct.

@daledah I have the back end PR ready, but I can't reproduce the issue anymore. Can you?

@cead22 I'm still able to reproduce:

@cead22 friendly bump

Thanks, the backend PR is in review

Backend PR is merged and should be deployed by EOD

Looks like the first problem in my proposal is fixed after the BE change:

@daledah the video isn't showing for me, but that's good news! Can you merge main into your App PR, test again, and remove the hold? cc @dominictb since you're the reviewer

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: invoice room avatar flickers when deleting workspace #52093

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

• @daledah requires payment automatic offer (Contributor)

@cead22 @johncschuster @daledah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

• [Contributor] Classify the bug:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

@daledah can you please complete the BZ Checklist above?

Just a heads up, I will be OOO starting December 23 and will be returning January 6th. A handful of folks on the BZ team will be online for a few days in between the 25th and the 1st, but we'll be operating with a skeleton crew. I will be issuing my payments when I return on January 6th. If you would like the payment issued sooner, please post this issue in #expensify-open-source and someone on the team will jump in.

Thank you!

@cead22, @johncschuster, @daledah Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@cead22, @johncschuster, @daledah Eep! 4 days overdue now. Issues have feelings too...