-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] Allow failed image/receipt uploads to be retried #50507
Comments
Triggered auto assignment to @sakluger ( |
|
Triggered auto assignment to Design team member for new feature review - @dannymcclain ( |
This is my first time creating a new feature request here so let me know if I'm missing something. I don't know that a project is necessary for improving UX here, is it? |
I don't really think so—but maybe that depends on how we solve the problem. I feel like we could just tweak the error message and add a retry link in the message. Maybe something like this? (bold = link)
|
I like tweaking the error message. Let's start there |
It was raised in slack that the word download actually doesn't make much sense here because when the error happens, the file was not yet uploaded. The file is actually being fetched from the user's device. |
So what happens when a user clicks that link currently? I'm sure we can tweak the error message to make sense if we understand what's actually happening. |
I believe it fetches the image from the user device. Downloading seems to imply that it's coming from an external source, like our servers or the Internet somewhere, when in reality, it's still on the user's device and just needs to be retried. |
Could we have it say:
? |
Yeah, I think that works. I wonder if it would be helpful to have a double confirmation before they dismiss the error warning them the receipt will be deleted forever. This has bitten me before while testing where I accidentally dismissed it and lost the receipt and having already thrown it out. |
Hmm yeah I could see that—we might want to get some other's to weigh in too. But if we wanted to go that route we could just use our standard confirmation modal. |
I tend to think one confirmation is enough, though I'll defer to y'all. |
I'm fine with that. I think the important part here is just getting the retry button in place to upload again. @sakluger what are the next steps here? I'm new to this process but happy to help from the internal engineering side. |
@justinpersaud can this be handled externally or does it need to be done by an internal engineer?
Either way, let's make sure the expected behavior in the OP is accurate. I updated it, can you review what I wrote up there? |
looks good to me, and I believe this is external because it's all happening with the application, not the backend. |
Job added to Upwork: https://www.upwork.com/jobs/~021849204620290416679 |
@nyomanjyotisa friendly bump |
Discussion opened in Slack |
This is still being discussed in Slack. |
@justinpersaud, @sakluger, @dannymcclain, @nyomanjyotisa, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Still discussing on Slack |
Bumped the Slack thread. |
That Slack thread is still ongoing. I will try to keep the conversation moving. |
@justinpersaud, @sakluger, @dannymcclain, @nyomanjyotisa, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too... |
I think we're close to wrapping up the Slack discussion. |
@justinpersaud, @sakluger, @dannymcclain, @nyomanjyotisa, @dukenv0307 Still overdue 6 days?! Let's take care of this! |
I think we've wrapped up the discussion in Slack. We're just waiting for @nyomanjyotisa's response in the thread. |
@justinpersaud, @sakluger, @dannymcclain, @nyomanjyotisa, @dukenv0307 10 days overdue. Is anyone even seeing these? Hello? |
Welp, one more decision left to make in that Slack thread. We are discussing whether to show an error message when offline. This depends on whether the file can be successfully downloaded while offline. |
@justinpersaud, @sakluger, @dannymcclain, @nyomanjyotisa, @dukenv0307 12 days overdue. Walking. Toward. The. Light... |
Waiting for @nyomanjyotisa's response here |
This issue has not been updated in over 14 days. @justinpersaud, @sakluger, @dannymcclain, @nyomanjyotisa, @dukenv0307 eroding to Weekly issue. |
@nyomanjyotisa Since the PR is close so please give an update here if you have. Thanks |
The draft PR is available here, and currently working on it |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: Any -- latest version
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @justinpersaud
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1728408442408079
Action Performed:
Break down in numbered steps
Unclear of the exact way to reproduce this, but you can upload a receipt via Submit Expense to another user and then somehow disrupt the upload either by losing internet connection or some other means.
Expected Result:
The receipt should fail to upload, and the error should say
There was an error uploading your receipt. **Try again**. Alternatively, **save the file** or dismiss this error to delete it.
"Try again" and "Save the file" should be linked.Actual Result:
The error asks the user to download the image and then upload it again which is not a great UX
Workaround:
Yes
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @nyomanjyotisaThe text was updated successfully, but these errors were encountered: