@neil-marcellini we could start with IOU.getTrackExpenseInformation, IOU.shareTrackedExpense, IOU.categorizeTrackedExpense after these three IOU.trackExpense.
These functions mostly share common data and could be refactored with ease for a start.
I would like to work on this and following if you want external contributor to work here.

Job added to Upwork: https://www.upwork.com/jobs/~021846632713060454080

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

Sure @ChavdaSachin, please go ahead and start with only IOU.categorizeTrackedExpense

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

📣 @ChavdaSachin 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Sounds good...

I am OOO for 2 days on an emergency business , will start working as soon as I am back.

@neil-marcellini, @ChavdaSachin, @dukenv0307 Huh... This is 4 days overdue. Who can take care of this?

work in progress.

@neil-marcellini, @ChavdaSachin, @dukenv0307 Still overdue 6 days?! Let's take care of this!

@neil-marcellini, @ChavdaSachin, @dukenv0307 10 days overdue. I'm getting more depressed than Marvin.

How's it coming along?

hi @neil-marcellini sorry for the delay, I am actually trying to implement it on a scale - coz all tracking functions are closely tied together, So I am figuring the whole network these functions have and refactor all at once so that would be a significant improvement and then all tracking related function would probably accept somewhere around 5-7 props that's it.
But it is taking time coz network is bigger.

I figured refactoring only one function - IOU.categorizeTrackedExpense would not be much of improvement so...
Let me take my time and trust me you would love the results.

Probably switch it to weekly.

@neil-marcellini, @ChavdaSachin, @dukenv0307 12 days overdue now... This issue's end is nigh!

Hi @ChavdaSachin. I appreciate your desire to tackle it all at once, but it's a lot easier for everyone involved if we do it in pieces. It will be faster to get the PR up for review and get it approved. I rather have many small PRs than one big one. Could you please split up your existing work into several PRs?

Sweet, here's the issue Refactor createDistanceRequest to use a parameter object.

Hi @neil-marcellini,

I see others are working on migrations. Is there another function I can help refactor to use a parameter object? Let me know!

Thanks!

@neil-marcellini next I could work on IOU.shareTrackedExpense function, could you creat new issue?
Thank you

@neil-marcellini bump on above^

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor IOU.categorizeTrackedExpense function #52221

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @ChavdaSachin requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)
• @mkzie2 requires payment automatic offer (Contributor)

BugZero Checklist:

• [Contributor] Classify the bug:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This is the refactor issue so no need for offending PR

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. Yes

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

Do we agree 👍 or 👎

@neil-marcellini Can you take a look at this comment? The PR here was merged for this issue already.

@neil-marcellini Next I think we can do with buildOptimisticTransaction (21 parameters).

Issue is ready for payment but no BZ is assigned. @OfstadC you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Payment Summary

• @ChavdaSachin paid $250 via Upwork
• @dukenv0307 paid $250 via Upwork
• @mkzie2 paid $250 via Upwork

@OfstadC I reviewed 2 PRs on this issue: #52231, #52221. I think we should create 2 separate issues as I mentioned here same as what we did for #53789 and others. If we decide to pay 2 PRs in this one, I should be paid 500$. Can you please check again? Thanks 🙏

Re-opening because this is a tracking issue for the project. Let's handle payment going forward in the separate sub-issues.

Hi, I created these two new issues and tagged you guys there. Please comment so I can assign. @dukenv0307 moving forward I'm going to let C get automatically assigned, because these PRs tend to be easier reviews and I think it's fair to spread those among other C now.

Refactor buildOptimisticTransaction to use a parameter object
Refactor shareTrackedExpense to use a parameter object

@neil-marcellini And then can you create a separate issue for that PR.?Thanks

@OfstadC, @neil-marcellini, @ChavdaSachin, @dukenv0307, @mkzie2 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!