Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Onboarding - 'Submit an expense' task gets marked as complete when tracking an expense #50178

Open
4 of 6 tasks
lanitochka17 opened this issue Oct 3, 2024 · 30 comments
Open
4 of 6 tasks

[$250] Onboarding - 'Submit an expense' task gets marked as complete when tracking an expense #50178

lanitochka17 opened this issue Oct 3, 2024 · 30 comments
Assignees
@greg-schroeder @thesahindia
Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Overdue Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 3, 2024 •
edited by greg-schroeder
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.44-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5039985
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with new Gmail account
  3. Select 'Get paid back by my employer' in onboarding modal
  4. Enter user name and submit modal
  5. Click on FAB > Track expense > Manual and finish the flow
  6. Navigate to Concierge chat

Expected Result:

'Submit an expense' onboarding task should remain unchecked as the expense is not submitted yet

Actual Result:

'Submit an expense' gets marked as complete when tracking an expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6623522_1727978883547.submit_an_expense_task.mp4

Note that the same issue can be observed when 'Chat and split expenses with friends' selected in onboarding modal
In this scenario, the 'Start a chat' task gets marked as completed when tracking an expense:

Bug6623522_1727978883563.2nd_scenario_-_start_a_chat_task.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021843765208299825426
  • Upwork Job ID: 1843765208299825426
  • Last Price Increase: 2024-10-08
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 3, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 3, 2024

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@greg-schroeder greg-schroeder added the External Added to denote the issue can be worked on by a contributor label Oct 8, 2024
@melvin-bot melvin-bot bot changed the title Onboarding - 'Submit an expense' task gets marked as complete when tracking an expense [$250] Onboarding - 'Submit an expense' task gets marked as complete when tracking an expense Oct 8, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021843765208299825426

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 8, 2024
@greg-schroeder greg-schroeder moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Oct 8, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot removed the Overdue label Oct 8, 2024
@kubabutkiewicz
Copy link
Contributor

Hello, Im Jakub from Callstack and would like to help with this issue

@kubabutkiewicz
Copy link
Contributor

This seems to me that its working as expected or issue on the BE, when making a TrackExpense command in the response we are getting onyx data which indicate that Submit an expense should be marked as completed
image

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 14, 2024

@greg-schroeder, @thesahindia Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@greg-schroeder greg-schroeder removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 14, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 14, 2024
@greg-schroeder
Copy link
Contributor

@kubabutkiewicz Okay so to be clear, Onyx Data shows this is actually expected in the end, and that "Submit an expense" is supposed to be checked there. Hmm. I wonder if it just needs to be re-named to "Create an expense" or if that is actually a bug?

@greg-schroeder
Copy link
Contributor

I am asking the team

@kubabutkiewicz
Copy link
Contributor

Okay so to be clear, Onyx Data shows this is actually expected in the end, and that "Submit an expense" is supposed to be checked there.

@greg-schroeder yes

@trjExpensify
Copy link
Contributor

Moving this out of wave-collect to #convert as an onboarding task related issue if we need to do something here.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 31, 2024

@kubabutkiewicz @greg-schroeder @thesahindia this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
@greg-schroeder
Copy link
Contributor

Same as above

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 1, 2024
@kubabutkiewicz
Copy link
Contributor

@greg-schroeder did someone from BE team checked this? because I don't think we can do something on frontend to fix that

@melvin-bot melvin-bot bot removed the Overdue label Nov 4, 2024
@greg-schroeder greg-schroeder added Internal Requires API changes or must be handled by Expensify staff Hot Pick Ready for an engineer to pick up and run with and removed External Added to denote the issue can be worked on by a contributor labels Nov 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
@greg-schroeder
Copy link
Contributor

Awaiting an internal volunteer

@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@greg-schroeder greg-schroeder added Weekly KSv2 Overdue and removed Daily KSv2 labels Nov 11, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 20, 2024
@greg-schroeder
Copy link
Contributor

Still waiting for a volunteer

@melvin-bot melvin-bot bot removed the Overdue label Nov 20, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Nov 29, 2024
@greg-schroeder
Copy link
Contributor

Awaiting a volunteer

@melvin-bot melvin-bot bot removed the Overdue label Dec 3, 2024
@greg-schroeder
Copy link
Contributor

Same as above

@melvin-bot melvin-bot bot added the Overdue label Dec 17, 2024
@greg-schroeder
Copy link
Contributor

Same as above

@melvin-bot melvin-bot bot removed the Overdue label Dec 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg-schroeder greg-schroeder

@thesahindia thesahindia

Labels
Bug Something is broken. Auto assigns a BugZero manager. Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff Overdue Weekly KSv2
Projects
[#whatsnext] #convert
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
6 participants
@trjExpensify @kubabutkiewicz @greg-schroeder @mvtglobally @lanitochka17 @thesahindia