Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console Error] Web - Expense - Too many requests console error when submitting and paying expenses consecutively #49500

Closed
1 of 6 tasks
IuliiaHerets opened this issue Sep 19, 2024 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): nathanmulugetatesting [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Create a workspace
  3. Submit and pay expenses on the workspace chat consecutively, at least more than 3 times

Expected Result:

No console error shown

Actual Result:

Console error with "Too many requests" is shown and RBR occurs on the expenses occasionally.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6608842_1726747936405.bandicam_2024-09-19_15-03-23-818.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@mallenexpensify mallenexpensify added Weekly KSv2 Daily KSv2 Needs Reproduction Reproducible steps needed and removed Daily KSv2 Weekly KSv2 labels Sep 20, 2024
@mallenexpensify
Copy link
Contributor

Console error bug, not priority, will address and reproduce soon.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 24, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 2, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mallenexpensify
Copy link
Contributor

Pinged Tomasz to check on summin

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 14, 2024
@mallenexpensify
Copy link
Contributor

Tomasz got back to me and I haven't been able to prioritize this yet

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 25, 2024
@mallenexpensify mallenexpensify changed the title Web - Expense - Too many requests console error when submitting and paying expenses consecutively [Console Error] Web - Expense - Too many requests console error when submitting and paying expenses consecutively Oct 30, 2024
@mallenexpensify
Copy link
Contributor

Checking to see if batching console errors for a v2 cleanup might be a good approach

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2024
@mallenexpensify
Copy link
Contributor

From @rinej in a 1:1. Sharing partially as a reminder to myself.

when we receive a 429 error, it usually means the user has sent too many requests within a given time frame. It seems the backend API has a rate limit in place to prevent this.
If this happens frequently, I think it would be best to adjust the rate limit on the server API side

@mallenexpensify
Copy link
Contributor

Off the next week then will revisit

@melvin-bot melvin-bot bot added the Overdue label Nov 15, 2024
@mallenexpensify
Copy link
Contributor

Submit and pay expenses on the workspace chat consecutively, at least more than 3 times

This is an edge case, the fact we haven't seen this reported much, if at all, the past 3 years makes me think it's not a bug most users would ever run into, going to close. Comment/reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants