Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@jliexpensify could you please assign me. I want to C this because I raised this issue

Job added to Upwork: https://www.upwork.com/jobs/~021835867544323146964

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

Done, I think Design is still weighing in though?

I'll post an update on the expected result whenever design team has reached a decision

Expected result:

1. On web, make it like gmail.
   a. You can select by tapping checkbox.
   b. If you tap a row, it’ll open the category.
   c. Tapping a row should not dismiss the selected categories

2. On mobile, if you’re in selection mode you should be able to tap anywhere to select the row.

(source)

@rushatgabhane Please review the PR that introduced this bug. I believe it will provide valuable insights for defining the final expectations.

Edited by proposal-police: This proposal was edited at 2023-10-07T16:31:35Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

RHP opened for the category and all other categories are reset (Unchecked)

What is the root cause of that problem?

• This useEffect logic:
  

  App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

  Lines 90 to 93 in 28e9fa9

  	if (isFocused) {
  	return;
  	}
  	setSelectedCategories({});

  cause the issue that all the selected categories are clear when we click on any category to open its detail page.

What changes do you think we should make in order to solve the problem?

• In this post, I will propose a solution that matches these requirements:

1. On web's requirements.

• Remove the logic causing this issue:
  

  App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

  Lines 89 to 94 in 28e9fa9

  	useEffect(() => {
  	if (isFocused) {
  	return;
  	}
  	setSelectedCategories({});
  	}, [isFocused]);

The similar logic should be removed in this, this and this.

• Then introduce a new hook. With this hook, it will not clear the selected options if user is navigated to RHN. Otherwise, clear the selected options :

import {NavigationContainerRefContext, useIsFocused} from '@react-navigation/native';
import {useContext, useEffect} from 'react';
import NAVIGATORS from '@src/NAVIGATORS';

let shouldCleanupSelectedOptions = false;

const useCleanupSelectedOptions = (setFunction: ({}: any) => void) => {
    const navigationContainerRef = useContext(NavigationContainerRefContext);
    const state = navigationContainerRef?.getState();
    const lastRoute = state.routes.at(-1);
    const isRightModalOpening = lastRoute?.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR;

    const isFocused = useIsFocused();

    useEffect(() => {
        if (isFocused || isRightModalOpening) {
            return;
        }
        shouldCleanupSelectedOptions = false;
        setFunction?.({});
    }, [isFocused, setFunction, isRightModalOpening]);
};

export {useCleanupSelectedOptions};

and just need to use that hook in where we want to clean up its selected option once we visit other pages, such as: In WorkspaceCategoriesPage, we use useCleanupSelectedOptions(setSelectedCategories), in WorkspaceTagsPage we use useCleanupSelectedOptions(setSelectedTags).

2. On mobile's requirements:

• Update this logic:

so that it will call toggleCategory(category) if isSmallScreenWidth && selectionMode?.isEnabled is true:

    const navigateToCategorySettings = (category: PolicyOption) => {
        if (isSmallScreenWidth && selectionMode?.isEnabled) {
            toggleCategory(category);
            return;
        }

What alternative solutions did you explore? (Optional)

1. On web's requirements.

• Remove the logic causing this issue:
  

  App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

  Lines 89 to 94 in 28e9fa9

  	useEffect(() => {
  	if (isFocused) {
  	return;
  	}
  	setSelectedCategories({});
  	}, [isFocused]);

I suggest removing that logic, as it was originally added to address an issue where: if you selected options on screen A, navigated to screen B, and returned to A, the selected options were not cleared. However, I believe this is standard behavior in terms of the navigation stack: when you select options on screen A, navigate to B, and then return to A, A's state should naturally be preserved.

Results for above proposal

Updated proposal to remove redundant code changes and add an explanation.

Let's go forward with @truph01's proposal. it addresses all requirements

C reviewed 🎀 👀 🎀

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@rushatgabhane just a note @truph01's solution do not clear categories even for other cases like switching to tags page and come back, so it does not align with the expectations.
Just to be more precise on expectations

1. selections should not clear after taping raw
2. selection should be cleared upon visiting other pages like Tags, Workflow, etc... and coming back

• this is what I concluded from expectations posted by you.

sorry i didn't know that we should remove selected categories if we navigate away

@ChavdaSachin for mobile, we want the categories to select if you tap anywhere on the row when in selection mode.
please update your proposal

give me a minute

spb Your proposal will be dismissed because you did not follow the proposal template.

Thanks Monil - so here's a tentative Payment Summary

• C: @truph01 $200
• C: @ChavdaSachin $50
• C : @rushatgabhane $250 (to be paid via N.D requests)

NEW UPWORKS JOB

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

Damn, I thought that would auto-create a new job (the old one is expired). Will manually create one then.

@truph01 what's your Upworks profile? Could you add it (or your name) to your GH profile? Thanks.

@jliexpensify I accepted this automatic offer. Correct amount ($200) could be paid out on that offer later.

@truph01 what's your Upworks profile? Could you add it (or your name) to your GH profile? Thanks.

Sure, I added my profile link to GH profile.

@truph01 thanks! Upworks does this annoying thing where after a month, it closes jobs and we can't pay out on them. So I had to create a new job and hire you.

PR is ready @rushatgabhane

I'm OOO until the 29th, feel free to reassign if payment is required before then - otherwise will handle when I get back.

@MonilBhavsar Do we want to address the issue "If we preserve selections and delete category from categorySettingsPage, selection counter on header would not update"? I've had a solution for it.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: when selecting categories, the selected categories get reset #53519

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @truph01 requires payment automatic offer (Contributor)
• @rushatgabhane requires payment through NewDot Manual Requests

@rushatgabhane @jliexpensify @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]