Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copilot - Selected access level is not highlighted #48965

Closed
6 tasks done
IuliiaHerets opened this issue Sep 11, 2024 · 6 comments
Closed
6 tasks done

Copilot - Selected access level is not highlighted #48965

IuliiaHerets opened this issue Sep 11, 2024 · 6 comments
Assignees
@dangrous @rushatgabhane @adelekennedy
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.32-0
Reproducible in staging?: Y
Reproducible in production?: N/A
Issue was found when executing this PR: #47353
Email or phone of affected tester (no customers): applausetester [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Security.
  3. Click Add copilot.
  4. Select a user.
  5. Select an access level.
  6. Click Access level on the confirmation page

Expected Result:

The selected access level will be highlighted.

Actual Result:

The selected access level is not highlighted.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6599487_1726023397402.20240911_105348.mp4

View all open jobs on GitHub
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 11, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 11, 2024

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 11, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 11, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot mentioned this issue Sep 11, 2024
Closed
58 tasks
@mkzie2
Copy link
Contributor

mkzie2 commented Sep 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

The selected access level is not highlighted.

What is the root cause of that problem?

We're missing initiallyFocusedOptionKey for this SelectionList:

App/src/pages/settings/Security/AddDelegate/SelectDelegateRolePage.tsx

Line 41 in 7ff29a6

<SelectionList

What changes do you think we should make in order to solve the problem?

Add initiallyFocusedOptionKey={route.params.role}

@rushatgabhane
Copy link
Member

not a blocker. @iwiznia @adelekennedy kindly assign it to me because im working on copilot project

@mountiny mountiny removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Sep 11, 2024
@mountiny mountiny added the Daily KSv2 label Sep 11, 2024
@iwiznia iwiznia removed their assignment Sep 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@rushatgabhane rushatgabhane mentioned this issue Sep 16, 2024
Merged
50 tasks
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 16, 2024

@dangrous, @rushatgabhane, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@dangrous dangrous added the Reviewing Has a PR in review label Sep 17, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@allgandalf allgandalf mentioned this issue Oct 4, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dangrous dangrous

@rushatgabhane rushatgabhane

@adelekennedy adelekennedy

Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Reviewing Has a PR in review
Projects
[#whatsnext] #expense
Status: Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@iwiznia @dangrous @rushatgabhane @mountiny @adelekennedy @IuliiaHerets @mkzie2