Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed
93 tasks done
github-actions bot opened this issue Aug 28, 2024 · 14 comments
Closed
93 tasks done

Deploy Checklist: New Expensify 2024-08-28 #48221

github-actions bot opened this issue Aug 28, 2024 · 14 comments
Assignees
@puneetlath @applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited by puneetlath
Loading

Release Version: 9.0.26-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Aug 28, 2024
@puneetlath puneetlath self-assigned this Aug 28, 2024
@neil-marcellini
Copy link
Contributor

Checking off #48118

@puneetlath
Copy link
Contributor

From the previous checklist:

#45150 - Pending validation on Desktop
#47123 - Pending validation on Native aps. Can you help validate internally?
#47607 - is failing on Desktop with #48147. Repro in PROD, checking off
#47678 - Failing on Android with original KI #47567 ok to check off?
#47816 - Failing with original KI #47240 (offline test). ok to check off?
#47821 - Pending validation on all platforms. Can you help validate internally?
#47844 - Pending validation on Desktop & failing with multiple issues
#47871 - Failing with #44148. repro in prod checking off
#48109 - it says it has not been deployed. Should we validate it?

@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.26-0 🚀

@Julesssss
Copy link
Contributor

Checked off #48244

@cristipaval
Copy link
Contributor

Checked off #48246

@kavimuru
Copy link

Regression is 75% of progress
unchecked PRs:
#37003 Failing on mWeb with original KI #33470 Pending validation on iOS
#46936 Pending validation on all platforms
#47038 Pending validation on iOS app
#47222 Pending validation on iOS app
#47338 Failing on iOS and Android apps with #48242
#47624 iOS validation pending
#47682 Desktop and iOS pending
#47709 Failing on Android only with #45765
#47726 mweb validation pending
#47753 iOS validation pending
#47761 iOS validation pending
#47764 mweb validation pending
#47781 validation pending
#47801 Pending validation on Web, mWeb.
#47809 Pending validation on iOS
#47829 Pending validation on iOS
#47832 - Pending validation on iOS
#47902 #47902 (comment)
#47920 - Pending validation on Desktop, Android and iOS
#47926 - Pending validation on all platforms
#47960 - Pending validation on Native apps
#47961 - Pending validation on Web, Desktop, Android and iOS
#47977 - Pending validation on Desktop and Android
#47978 - Pending validation on mWeb, Desktop, Android, iOS
#47993 - Pending validation on Native apps
#47999 - Pending validation on mWeb, Desktop, Android, iOS
#48006 - Pending validation on all platforms
#48010 - Pending validation on Native apps
#48145 - Failing on Android with #43397 Pending validation iOS
#48196 - Pending validation on iOS

@Julesssss
Copy link
Contributor

Checked off #48254 as i cannot reproduce. Magic code sign-in worked for me on both staging and prod Android apps.

@youssef-lr
Copy link
Contributor

Checking off #48245, new feature and low priority issue

@kavimuru
Copy link

kavimuru commented Aug 29, 2024 •
edited
Loading

Regression is 9% left

unchecked PRs:
#37003 #37003 - Failing on mWeb with original KI #33470
#47038 #47038 - Pending validation on iOS app
#47338 #47338 - Failing on iOS and Android apps with #48242
#47472 Failing with #46104 in web mbwe desktop and andriod (ios pending)
#47624 iOS validation pending
#47682 Desktop and iOS pending
#47709 #47709 - Failing on Android only with #45765
#47764 Failing with the original KI in mweb #46891
#47781 validation pending
#47787 Failing with #48240
#47801 Pending validation on Web, mWeb.
#47809 #47809 - Pending validation on iOS
#47829 #47829 - Pending validation on iOS
#47832 Failing in iOS with #48263
#47902 #47902 (comment)
#47920 #47920 - Pending validation on iOS
#47926 #47926 - Pending validation on all platforms
#47960 #47960 - Pending validation on iOS
#47961 #47961 - Pending validation on iOS
#47977 #47977 - Pending validation on mweb
#47978 #47978 - Pending validation on mWeb, Android, iOS
#47993 #47993 - Pending validation on iOS
#47999 #47999 - Pending validation on iOS
#48006 #48006 - Pending validation on all platforms
#48010 #48010 - Pending validation on iOS
#48145 #48145 - Failing on Android with #43397 Pending validation iOS
#48196 #48196 - Pending validation on iOS
#48074 Pending validation in iOS

@kavimuru
Copy link

kavimuru commented Aug 29, 2024 •
edited
Loading

Regression is still 2% left.

Unchecked PRs:
#37003 #37003 - Failing on mWeb with original KI #33470
#47338 #47338 - Failing on iOS and Android apps with #48242
#47472 Failing with #46104
#47682 Desktop and iOS pending
#47709 #47709 - Failing on Android only with #45765
#47764 Failing with the original KI in mweb #46891
#47787 Failing with #48240
#47801 Pending validation on Web, mWeb.
#47809 Failing in iOS with #48305, repro in production checking it off
#47832 Failing in iOS with #48263
#47902 #47902 (comment)
#47926 #47926 - Pending validation on all platforms
#48145 #48145 - Failing on Android with #43397 Pending validation iOS
#48074 Pending validation in iOS
#48196 failing with #47810 in web

@kavimuru
Copy link

Regression is 2% left

Unchecked PRs:
#37003 - Failing in mWeb with original KI #33470, checking it off
#47338 - Failing on iOS and Android apps with #48242
#47472 Failing with original KI #46104, checking it off
#47682 Desktop and iOS pending validation
#47709 - Failing on Android only with #45765
#47764 Failing with the original KI in mweb #46891
#47787 Failing with #48240
#47801 Pending validation on Web, mWeb.
#47809 Failing in iOS with #48305, repro in production checking it off
#47832 Failing in iOS with #48263
#47902 (comment)
#47926 - Pending validation on all platforms
#48145 - Failing on Android with #43397 Pending validation iOS
#48196 failing in web and waiting for the tester to log bug
#46936 checked off as per #46936 (comment)
Deploy blockers:
#48197
#48242
#48296
#48298

@tsa321
Copy link
Contributor

tsa321 commented Aug 30, 2024 •
edited
Loading

For #47472 , the PR was reverted by #48135 due to lint and typecheck errors during merging.

@mvtglobally
Copy link

mvtglobally commented Aug 30, 2024 •
edited
Loading

Regression is Completed

Unchecked PRs:
#47338 - Failing on iOS and Android apps with #48242
#47787 Failing with #48240. pls double check as it was re-opened
#47902 (comment) - Can you QA internally ?

Checking off PRs
#48145 - Failing on Android with https://github.com/Expensify/App/issues/43397.repro in PROD checking off
#47682 - issue repro #34757, checking off
#47709 - Failing on Android only with #45765. repro in PROD Checking off

Deploy blockers:
#48197
#48298

@puneetlath
Copy link
Contributor

:shipit:

This was referenced Aug 30, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 31, 2024
Closed
Closed
Closed
Closed
This was referenced Aug 31, 2024
Closed
Closed
Closed
@situchan situchan mentioned this issue Sep 2, 2024
Closed
6 tasks
@ishpaul777 ishpaul777 mentioned this issue Sep 5, 2024
Closed
6 tasks
This was referenced Sep 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puneetlath puneetlath

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@puneetlath @youssef-lr @Julesssss @cristipaval @neil-marcellini @applausebot @mvtglobally @kavimuru @OSBotify @tsa321