Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Expense - App crashes after disabling billable option when expense is flagged as duplicate #48159

Closed
1 of 6 tasks
izarutskaya opened this issue Aug 28, 2024 · 18 comments
Closed
1 of 6 tasks

[$250] Expense - App crashes after disabling billable option when expense is flagged as duplicate #48159

izarutskaya opened this issue Aug 28, 2024 · 18 comments
Assignees
@yuwenmemon @johncschuster
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 28, 2024 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: v9.0.25-8
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4895077
Email or phone of affected tester (no customers): applausetester [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • Billable option is set to Default to billable on Old Dot.
  1. Launch New Expensify app.
  2. Go to workspace chat.
  3. Submit two same expenses with billable option enabled.
  4. On Old Dot, disable billable feature.
  5. On New Dot, go to transaction thread of any submitted expense.
  6. Wait until "Billable no longer valid" violation shows up (might need to visit the page a few times for it to show up) (important).
  7. Make sure the expense is flagged as duplicate with Review duplicates button above (important).
  8. Tap on the billable toggle to disable it.

Expected Result:

App will not crash.

Actual Result:

App crashes after disabling billable option when billable option is no longer valid and expense is flagged as duplicate.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6584552_1724789167871.ScreenRecording_08-28-2024_03-53-05_1.mp4

Bug6584552_1724789167869!New_Expensify-2024-08-28-022109.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018fe556ab86ba6c36
  • Upwork Job ID: 1828931686395102772
  • Last Price Increase: 2024-09-04
Issue OwnerCurrent Issue Owner: @allgandalf
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Aug 28, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya
Copy link
Author

Production

RPReplay_Final1724840342.MP4

@izarutskaya
Copy link
Author

We think this issue might be related to the #wave-control

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

📣 @HTneko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

📣 @LC-JiaZhaorong! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@stitesExpensify stitesExpensify added DeployBlockerCash This issue or pull request should block deployment and removed DeployBlocker Indicates it should block deploying the API labels Aug 28, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@stitesExpensify
Copy link
Contributor

Switching this to cash only deploy blocker since this only happens on iOS

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot mentioned this issue Aug 28, 2024
Closed
93 tasks
@yuwenmemon yuwenmemon added the External Added to denote the issue can be worked on by a contributor label Aug 28, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

Job added to Upwork: https://www.upwork.com/jobs/~018fe556ab86ba6c36

@melvin-bot melvin-bot bot changed the title Expense - App crashes after disabling billable option when expense is flagged as duplicate [$250] Expense - App crashes after disabling billable option when expense is flagged as duplicate Aug 28, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 28, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

@allgandalf
Copy link
Contributor

Able to reproduce on iOS, waiting for proposals

@puneetlath
Copy link
Contributor

Demoting since duplicate detection is under beta.

@puneetlath puneetlath added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 29, 2024
@allgandalf
Copy link
Contributor

@izarutskaya can the QA please retest this?

@allgandalf
Copy link
Contributor

@puneetlath can you put a retest label on this one please?

@puneetlath puneetlath added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Sep 3, 2024
@johncschuster
Copy link
Contributor

I've also asked for a retest here

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 4, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2024
@yuwenmemon yuwenmemon added Weekly KSv2 and removed Daily KSv2 labels Sep 4, 2024
@melvin-bot melvin-bot bot removed the Overdue label Sep 4, 2024
@mvtglobally
Copy link

Issue is Not reproducible

trim.FB945F46-6CA1-40F1-BCFC-06DBB7EADDED.MOV

@allgandalf
Copy link
Contributor

Lets close this one then 👍

@allgandalf allgandalf removed their assignment Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuwenmemon yuwenmemon

@johncschuster johncschuster

Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@puneetlath @yuwenmemon @johncschuster @stitesExpensify @mvtglobally @allgandalf @izarutskaya and others