Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sakluger FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-vsp

Proposal

Please re-state the problem that we are trying to solve in this issue.

Emoji markdown when edited is cut off on top.

What is the root cause of that problem?

When the text is only emoji, the line height will be 35.

When we edit the message, an (edited) text is added at the end of the text. The line height of this is smaller than the emoji, thus the emoji is cut off.

This only started to happen when we render the emoji as a markdown/html. When it was still rendered as a plain text, we already apply the line height style to the edited text, so the issue doesn't happen.

What changes do you think we should make in order to solve the problem?

We can follow the similar pattern of adding islarge attribute to the emoji tag here,

const editedTag = fragment?.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''} ${containsOnlyEmojis ? 'islarge' : ''}></edited>` : '';

Then in the edited renderer, apply the emoji only line height if islarge is true.

const isLarge = !!(tnode.attributes.islarge !== undefined);

<Text style={isLarge && styles.onlyEmojisTextLineHeight}>
    <Text
        style={[styles.userSelectNone, isLarge && styles.onlyEmojisTextLineHeight]}

We need to apply the line height style to the empty space text too because our text component has a default line height value if the font size is normal. (you can see we did this too in the plain text code that I put in the root cause section)

Or I think the better way is to set a font size for the empty space to be the same as the (edited) text, that is fontSize={variables.fontSizeSmall}.

<Text style={isLarge && styles.onlyEmojisTextLineHeight}>
    <Text
        style={styles.userSelectNone}
        fontSize={variables.fontSizeSmall}

Let me know which one to do!

Job added to Upwork: https://www.upwork.com/jobs/~01b3f0154fe463e8cd

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@bernhardoj's proposal makes sense here.

Or I think the better way is to set a font size for the empty space to be the same as the (edited) text

Let's go with this approach.

🎀👀🎀 C reviewed.

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

PR is ready

cc: @akinwale

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix emoji with markdown on edit cut off on top #43634

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @akinwale requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Summarizing payment on this issue:

Contributor: @akinwale $250, paid via Upwork
Contributor : @bernhardoj $250, paid via Upwork

@akinwale could you please complete the BZ checklist?

• [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
• [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression.

• [@akinwale] Determine if we should create a regression test for this bug.
• [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. Launch Expensify.
2. Open any report.
3. Send a message with only emoji (😄).
4. Edit the previously sent message and wrap the emoji in markdown, eg italics (😄).
5. Verify that the emoji is not cut off at the top.

Do we agree 👍 or 👎?

Thanks! I created the GH issue to update regression test steps.