Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Held on Onfido upstream fix] [$250] Connect Bank - Page loads infinitely when clicking back button on "Continue on your phone" page #41398

Open
2 of 6 tasks
izarutskaya opened this issue May 1, 2024 · 69 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Overdue Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented May 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.69-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when executing PR : #40402
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings.
  3. Go to Workflows.
  4. Go to Connect bank account.
  5. Click Connect manually.
  6. On Personal information, enter "First" and "Last" as first name and last name respectively.
  7. Proceed to Onfido flow.
  8. Accept the terms.
  9. On "Continue on your phone" page, click on the blue back button.

Expected Result:

App returns to previous page.

Actual Result:

The page loads infinitely.
On mweb, the back button is not responsive.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6467589_1714550806295.20240501_160104.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013867ab061a360e2f
  • Upwork Job ID: 1792533118121684992
  • Last Price Increase: 2024-09-23
Issue OwnerCurrent Issue Owner: @muttmuure
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 1, 2024
Copy link

melvin-bot bot commented May 1, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@izarutskaya
Copy link
Author

We think this issue might be related to the #collect project.

@melvin-bot melvin-bot bot added the Overdue label May 3, 2024
Copy link

melvin-bot bot commented May 7, 2024

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

@muttmuure
Copy link
Contributor

I think this might be a site slow problem

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels May 7, 2024
@muttmuure
Copy link
Contributor

Can we retest this? I'm not sure it is still happening

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
Copy link

melvin-bot bot commented May 15, 2024

@muttmuure this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 17, 2024
@muttmuure muttmuure added the External Added to denote the issue can be worked on by a contributor label May 20, 2024
@melvin-bot melvin-bot bot changed the title Web- Onfido - Page loads infinitely when clicking back button on "Continue on your phone" page [$250] Web- Onfido - Page loads infinitely when clicking back button on "Continue on your phone" page May 20, 2024
Copy link

melvin-bot bot commented May 20, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013867ab061a360e2f

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 20, 2024
Copy link

melvin-bot bot commented May 20, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@muttmuure
Copy link
Contributor

I can reproduce this

@melvin-bot melvin-bot bot removed the Overdue label May 20, 2024
@muttmuure
Copy link
Contributor

image

@tienifr
Copy link
Contributor

tienifr commented May 21, 2024

Seems like the same issue outlined here but useMemoryHistory was deprecated in version 14.15.0. Their source code is packaged and minified so I couldn't take a look. I think we need to file a bug to them.

@eVoloshchak
Copy link
Contributor

Can reproduce the bug on staging

I agree with @tienifr, this is a bug in onfido lib, let's file a bug to them.
@muttmuure, do we have a process for that?

@kbecciv kbecciv changed the title [$250] Web- Onfido - Page loads infinitely when clicking back button on "Continue on your phone" page [$250] Connect Bank - Page loads infinitely when clicking back button on "Continue on your phone" page May 24, 2024
@melvin-bot melvin-bot bot added the Overdue label May 24, 2024
Copy link

melvin-bot bot commented May 27, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented May 27, 2024

@eVoloshchak, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

@eVoloshchak
Copy link
Contributor

@muttmuure, what is your opinion on #41398 (comment)?

@trjExpensify trjExpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 27, 2024
@trjExpensify trjExpensify moved this to Tracking issues in [#whatsnext] #wave-collect Sep 27, 2024
@trjExpensify trjExpensify changed the title [$250] Connect Bank - Page loads infinitely when clicking back button on "Continue on your phone" page [Held on Onfido upstream fix] [$250] Connect Bank - Page loads infinitely when clicking back button on "Continue on your phone" page Sep 27, 2024
@muttmuure
Copy link
Contributor

Nice, yeah it was just a bug that applause found actually. But it's down to Onfido to fix it, we can't do it.

@trjExpensify
Copy link
Contributor

Sounds good!

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2024
@muttmuure
Copy link
Contributor

muttmuure commented Oct 16, 2024

Hi Matt,

I have got an answer back from Dev team, and the fix has been rolled out on v14.38.0.

I hope this information helps. Please test this on your end, and let me know if you are happy with this resolution or if you require further assistance.

Kind Regards,
Thiago Farias
Product Support Engineer

@muttmuure
Copy link
Contributor

What do we need to do to update to the new Onfido version?

@eVoloshchak
Copy link
Contributor

What do we need to do to update to the new Onfido version?

@muttmuure, we need to open an App PR and bump the @onfido/react-native-sdk version to 14.38.0 (assuming there are no breaking changes, which we have to thoroughly test for, since we're using a pretty old version of 10.6.0)

However, I don't see 14.38.0 on Onfido's releases page, the latest there is v13.2.0

@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2024
@muttmuure
Copy link
Contributor

weird

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2024
@muttmuure
Copy link
Contributor

I will move to Quality and make this a hot pick

@muttmuure
Copy link
Contributor

Emailed Thiago

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
@muttmuure
Copy link
Contributor

I bumped Thiago

@melvin-bot melvin-bot bot removed the Overdue label Nov 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2024
@muttmuure
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
@shubham1206agra
Copy link
Contributor

@muttmuure I think they were talking about https://github.com/onfido/onfido-sdk-ui/releases. If thats the case, can I take a crack at the upgrade to atleast 14.38.0 (Currently at 14.15.0)?

@melvin-bot melvin-bot bot added the Overdue label Dec 13, 2024
@muttmuure
Copy link
Contributor

That would be great! Let's maybe share this in Open Source

@melvin-bot melvin-bot bot removed the Overdue label Dec 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Overdue Weekly KSv2
Projects
Status: Tracking issues
Development

No branches or pull requests

6 participants