Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero process steps for feature requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@Expensify/design should we try to roll image and description updates into this as well? I'm thinking for those two, the system message could just be:

Username
changed the description for this group.

Username
changed the avatar of this group.

Or something like that. Basically I'm just thinking something slightly more generic/that doesn't include what the value was actually changed to. (I don't feel too strongly, just throwing it out there!)

Hmm I don't feel too strongly - I suppose the group/room description is easily viewable in the header as well as the details view, so we don't necessarily need it. But the big thing for me is that it kind of creates an inconsistency with other places, where we do say what the value changed to. For example, categories/departments on an expense:

So I think I lean towards including it, but I also don't feel strongly.

Hmm yeah that's a good point. I guess I don't feel super strongly about not including it. I guess I was just thinking that it may be kinda long—but I don't know if that should really be a concern. I would be totally down to include it like we would do with the room/group name.

Yeah I don't actually mind including what the description was set to. Allows users to not having to navigate to see it too. But don't feel too strongly.

Ok cool. In that case I would say if we incorporate that update into this, let's just show what the description was changed to!

Agree with showing when a description was changed.

Just checking on this as we're missing an external/internal label. I think this can be external @marcaaron can you confirm?

@Christinadobrzyn system messages are backend. I hope you don't mind, but I'm going to take this one over as we try to finish up the initial scope of the design doc.

Any update on this one?

@JmillsExpensify anything new for this?

Ah, sorry in what sense. I think I might have misunderstand this comment from you. As in, did we land on not showing update to the description, or showing them?

@Expensify/design should we try to roll image and description updates into this as well? I'm thinking for those two, the system message could just be:

Username
changed the description for this group.

Username
changed the avatar of this group.

Or something like that. Basically I'm just thinking something slightly more generic/that doesn't include what the value was actually changed to. (I don't feel too strongly, just throwing it out there!)

We landed on showing the description.

So I think we'd have something like this:

Username
renamed this group from "Danny, Jason, Shawn" to "Grand Canyon Crew".

Username
set the description of this group to "We're going to the Grand Canyon! Let's chat about all our plans and split all our expenses here in this group. It's going to be fun on a bun!"

Username
changed the avatar for this group.

Basically just following the same patterns we use for expenses where every change/update triggers a system message that creates a "history trail" of what's happened.

Gotcha. For this one...

Username
renamed this group from "Danny, Jason, Shawn" to "Grand Canyon Crew".

Would this be more consistent?

Username
renamed this group to "Grand Canyon Crew" (previously "Danny, Jason, Shawn")

Yeah that works! I was just going off of what the current message says:

But that doesn't really matter. I agree what you've proposed is more consistent with how we handle other updates.

Cool, sounds good. So then I think we're good to get this one kicked off when an Expensify engineer is ready to pick it up.

Not overdue, basically still just waiting for the right time.

Still held on group chats implementation.

Same

Still on hold Melv.

Haha yeah same same

Still holding Melv.

Same same

Same³

All the same