Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultSettings.json does not list the valid options for configure scroll sync mode #87

Closed
Enivex opened this issue Aug 18, 2023 · 5 comments · Fixed by #89
Closed

defaultSettings.json does not list the valid options for configure scroll sync mode #87

Enivex opened this issue Aug 18, 2023 · 5 comments · Fixed by #89

Comments

@Enivex
Copy link

Enivex commented Aug 18, 2023 •
edited
Loading

The file reads as follows:

	// Configure scroll sync mode.
	//  - never: Scroll preview to current cursor position when selection changes
	"typst-preview.scrollSync": "onSelectionChange",

Only "never" is listed, and this is not even the default value. The description is also wrong.

The issue seems to be here

typst-preview/addons/vscode/package.json

Line 97 in 2f184f6

"enumDescriptions": [

There is no description for never.
@Enter-tainer
Copy link
Owner

what is default setting.json? i remember i put everything related to config in package.json
Screenshot_2023-08-18-18-15-08-456_com.github.android.jpg

@Enter-tainer
Copy link
Owner

okay this should be something generated by vscode. So we just need update the enum description

@Enter-tainer
Copy link
Owner

but i still don't quite understand the issue title. when use vscode ui to edit config, there should exist a drop down menu, listing all valid options.

@Enivex
Copy link
Author

Enivex commented Aug 18, 2023 •
edited
Loading

but i still don't quite understand the issue title. when use vscode ui to edit config, there should exist a drop down menu, listing all valid options.

I never use the UI to edit the configuration. I edit my settings.json manually, informed by defaultSettings.json

@Myriad-Dreamin
Copy link
Collaborator

At least the enumDescriptions list is incomplete corresponding to the enum list. Looks like it must be one-to-one mapping, so the onSelectionChange is missing in the generated description.

@Enter-tainer Enter-tainer mentioned this issue Aug 19, 2023
Merged
@Enter-tainer Enter-tainer mentioned this issue Aug 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add description for typst-preview.scrollSync Enter-tainer/typst-preview
3 participants
@Enivex @Enter-tainer @Myriad-Dreamin