Set log level via RUST_LOG #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…> for more information
davidpdrsn
reviewed
Mar 7, 2023
src/process/tests.rs
Outdated
| @@ -221,7 221,6 @@ async fn no_description_none_required_pr_actions() { | |||
| async fn review_not_required_if_label_not_configured() { | |||
| use ReviewState::{Approved, ChangesRequested, Commented}; | |||
|
|
|||
| #[track_caller] | |||
There was a problem hiding this comment.
nit: I think should keep this as possible test failures will point at the corresponding assert_approved below, instead of where this function calls assert_eq
There was a problem hiding this comment.
I can re-add it, but according to rust-lang/rust#87417 it will do nothing (if I understand it correctly). I guess it will eventually be fixed, so I can re-add and ignore the warning instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Set log level via the RUST_LOG env variable using
EnvFilter. If not set, fall back to info level