Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure fiber is properly cleared in FiberHandle.unsafeSet #3435

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Aug 8, 2024

This was caught by this TS experiment I"m running: microsoft/TypeScript#59559 . I believe this to be the correct change :P

@Andarist Andarist requested a review from mikearnaldi as a code owner August 8, 2024 16:28
Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 43bc9c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-kysely Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you"re a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart changed the title Fix fiber reset at one call site ensure fiber is properly cleared in FiberHandle.unsafeSet Aug 8, 2024
Copy link
Contributor

@tim-smart tim-smart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@tim-smart tim-smart merged commit fd4b2f6 into main Aug 8, 2024
11 checks passed
@tim-smart tim-smart deleted the Andarist-patch-1 branch August 8, 2024 22:06
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants