Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release queue: minor #3410

Merged
merged 12 commits into from
Aug 30, 2024
Merged

Release queue: minor #3410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift click to select a range
1bbdc61
add `propagateInterruption` option to Fiber{Handle,Set,Map} (#3407)
tim-smart Aug 4, 2024
8e63c05
return Exit values from `Fiber.awaitAll` (#3147)
patroza Aug 12, 2024
2af6932
Avoid automatic propagation of finalizer concurrency, closes #3440 (#…
mikearnaldi Aug 14, 2024
207022e
preserve `Array.replace` `Array.replaceOption` non emptiness (#3491)
KhraksMamtsov Aug 22, 2024
bc3a173
fix Array.replaceOption signature (#3497)
gcanti Aug 22, 2024
ab3e1cf
Preserve `Array.modify` and `Array.modifyOption` non emptiness (#3496)
vinassefranche Aug 22, 2024
3b61687
feat(Stream): race (#3305)
dilame Aug 23, 2024
57d0537
feat(`effect/Micro)`: add isMicroCause (#3501)
juliusmarminge Aug 26, 2024
872abf3
Introduce `bindAll` (#3486)
KhraksMamtsov Aug 29, 2024
08c8884
Add a Config constructor : `Config.stringNonEmpty ` (#3514)
titouancreach Aug 30, 2024
f114c96
rename Config.stringNonEmpty to nonEmptyString (#3517)
tim-smart Aug 30, 2024
327cd82
add HttpApi modules to /platform (#3495)
tim-smart Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix Array.replaceOption signature (#3497)
  • Loading branch information
@gcanti @tim-smart
gcanti authored and tim-smart committed Aug 30, 2024
commit bc3a1731190bf35fab2c28c973ffbeb569cc71c9
44 changes: 39 additions & 5 deletions packages/effect/dtslint/Array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,17 1342,51 @@ Array.getSomes(hole<Iterable<Option.Option<number>> | Iterable<Option.Option<str
// $ExpectType string[]
Array.replace([], 0, "a")

// $ExpectType ("a" | 1 | 2)[]
Array.replace(new Set([1, 2] as const), 0, "a" as const)
// $ExpectType (string | number)[]
Array.replace(numbers, 0, "a")

// $ExpectType [number | "a", ...(number | "a")[]]
Array.replace(Array.of(1), 0, "a" as const)
Array.replace(nonEmptyNumbers, 0, "a" as const)

// $ExpectType ("a" | 1 | 2)[]
Array.replace(new Set([1, 2] as const), 0, "a" as const)

// $ExpectType string[]
pipe([], Array.replace(0, "a"))

// $ExpectType (string | number)[]
pipe(numbers, Array.replace(0, "a"))

// $ExpectType [number | "a", ...(number | "a")[]]
pipe(nonEmptyNumbers, Array.replace(0, "a" as const))

// $ExpectType ("a" | 1 | 2)[]
pipe(new Set([1, 2] as const), Array.replace(0, "a" as const))

// $ExpectType [number | "a", ...(number | "a")[]]
pipe(Array.of(1), Array.replace(0, "a" as const))
// -------------------------------------------------------------------------------------
// replaceOption
// -------------------------------------------------------------------------------------

// $ExpectType Option<string[]>
Array.replaceOption([], 0, "a")

// $ExpectType Option<(string | number)[]>
Array.replaceOption(numbers, 0, "a")

// $ExpectType Option<[number | "a", ...(number | "a")[]]>
Array.replaceOption(nonEmptyNumbers, 0, "a" as const)

// $ExpectType Option<("a" | 1 | 2)[]>
Array.replaceOption(new Set([1, 2] as const), 0, "a" as const)

// $ExpectType Option<string[]>
pipe([], Array.replaceOption(0, "a"))

// $ExpectType Option<(string | number)[]>
pipe(numbers, Array.replaceOption(0, "a"))

// $ExpectType Option<[number | "a", ...(number | "a")[]]>
pipe(nonEmptyNumbers, Array.replaceOption(0, "a" as const))

// $ExpectType Option<("a" | 1 | 2)[]>
pipe(new Set([1, 2] as const), Array.replaceOption(0, "a" as const))
6 changes: 2 additions & 4 deletions packages/effect/src/Array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,7 1049,7 @@ export const insertAt: {
* import { Array } from "effect"
*
* const letters = ['a', 'b', 'c', 'd']
* const result = Array.replace(1, 'z')(letters)
* const result = Array.replace(letters, 1, 'z')
* assert.deepStrictEqual(result, ['a', 'z', 'c', 'd'])
*
* @since 2.0.0
Expand Down Expand Up @@ -1084,9 1084,7 @@ export const replaceOption: {
<B>(
i: number,
b: B
): <A, S extends Iterable<A> = Iterable<A>>(
self: Iterable<A>
) => Option<ReadonlyArray.With<S, ReadonlyArray.Infer<S> | B>>
): <A, S extends Iterable<A> = Iterable<A>>(self: S) => Option<ReadonlyArray.With<S, ReadonlyArray.Infer<S> | B>>
<A, B, S extends Iterable<A> = Iterable<A>>(
self: S,
i: number,
Expand Down