Add Envelope type to cluster
#3155
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 06e8685 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you"re a maintainer who wants to add another changeset to this PR |
tim-smart
reviewed
Jul 4, 2024
tim-smart
reviewed
Jul 10, 2024
IMax153
force-pushed
the
feat/envelope
branch
6 times, most recently
from
8acc4a0 to
33926fb
Compare
tim-smart
reviewed
Aug 21, 2024
| * @since 1.0.0 | ||
| * @category models | ||
| */ | ||
| export type Entity<Msg extends TaggedRequest.Any> = |
There was a problem hiding this comment.
Given the description of a RecipientType:
"A RecipientType is basically a pointer to a logical grouping of multiple entities"
I don"t think Entity is the right name for this refactor.
Maybe something like:
type EntityGroup = Single | Multiple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Related