add lwM2M gateway design #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomqin93
reviewed
Sep 29, 2024
kris21he
reviewed
Oct 9, 2024
kris21he
reviewed
Oct 9, 2024
kris21he
reviewed
Oct 9, 2024
rhoninl
force-pushed
the
add_lwM2M_gateway_design
branch
from
68f4f78
to
5622b6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 /- ##
==========================================
Coverage 37.60% 37.93% 0.33%
==========================================
Files 46 46
Lines 2976 2976
==========================================
Hits 1119 1129 10
Misses 1737 1730 -7
Partials 120 117 -3 ☔ View full report in Codecov by Sentry. |
tomqin93
reviewed
Oct 10, 2024
tomqin93
reviewed
Oct 10, 2024
tomqin93
reviewed
Oct 10, 2024
tomqin93
previously approved these changes
Oct 10, 2024
kris21he
reviewed
Oct 11, 2024
kris21he
reviewed
Oct 11, 2024
| 1. Start the LwM2M client and obtain all device information from deviceShifu. | ||
| 2. Register the device with the server and update the device information. | ||
| 3. Handle requests from the server. | ||
| 4. If the server enables the Observe feature, notify the server when data changes or a timeout occurs. |
There was a problem hiding this comment.
which timeout? do you mean there is an interval can be configured?
There was a problem hiding this comment.
The interval is configured by the LwM2M server, but it resets whenever the data changes. i think interval is not good for this
kris21he
reviewed
Oct 11, 2024
kris21he
reviewed
Oct 11, 2024
kris21he
reviewed
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
for deviceshifu only support http protocol and telemetryservice is hard to support lwM2M which protocol have pull and push at the same time
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #How is this PR tested
documentation no need test
Special notes for your reviewer:
Release note: