Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbeucher
changed the title
|
@flicj191 can you have a look please? |
flicj191
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Thanks @max-anu, it looks to be working well,
Can you have a look at the Codacy/CI tests? it looks like the downloader script needs an empty line at the end of it,
not sure why its not building the docs but I've suggested cleaning the whitespace in the table to make the file formatted cleaner
I would also add the filenames in the formatter script description string (esmvaltool/cmorizers/data/formatters/datasets/noaa_cires_20cr_v2.py) to complete it
Cheers
Co-authored-by: Felicity Chun <32269066 [email protected]>
|
Sanity checking values: global and annual means for *pr*
and annual means for extended ENSO region *pr* looks good
*tauv* for extended ENSO region
tauu need to check the direction/positive attribute @max-anu: |
|
Thanks @flicj191 ! |
|
tauu and tauv have both been flipped. I believe this is everything which needs to be done. |
rbeucher
approved these changes
Oct 14, 2024
|
OK @flicj191 can you do a last pass and merge please? |
flicj191
requested changes
Oct 15, 2024
11 tasks
flicj191
approved these changes
Oct 16, 2024
|
Data needs to be added to Levante first. |
|
Raw data and CMORised data has been copied to DKRZ: |
ehogan
added a commit
that referenced
this pull request
Nov 19, 2024
* main: (31 commits) Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811) Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810) Remove recipe filler utility (#3777) [Condalock] Update Linux condalock file (#3809) change authors name (#3806) [Condalock] Update Linux condalock file (#3798) Fix contourf plots for masked data (#3797) [Condalock] Update Linux condalock file (#3796) Add next release schedule (#3794) Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789) Pin pys2index >=0.1.5 in osx environment (#3792) Adding a CMORiser for CMAP data for pr (#3766) Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765) Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785) Adapt ESMValTool to new configuration (#3761) Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763) update comment in conda lock creation Github action (#3788) [Condalock] Update Linux condalock file (#3786) update Docker builds badge in README (#3783) Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771) ...
ehogan
added a commit
that referenced
this pull request
Nov 19, 2024
…Tool into 3723_remove_rose_cylc * '3723_remove_rose_cylc' of github.com:ESMValGroup/ESMValTool: (31 commits) Update environment: pin `iris>=3.11`, unpin `cartopy` and allow for `numpy >=2` (#3811) Fix issue related to removal/change of private function imported in `diag_scripts/shared/_supermeans.py` (deprecation in iris=3.11) (#3810) Remove recipe filler utility (#3777) [Condalock] Update Linux condalock file (#3809) change authors name (#3806) [Condalock] Update Linux condalock file (#3798) Fix contourf plots for masked data (#3797) [Condalock] Update Linux condalock file (#3796) Add next release schedule (#3794) Use `transform_first=True` for contourf plots with Robinson projection to avoid cartopy bug (#3789) Pin pys2index >=0.1.5 in osx environment (#3792) Adding a CMORiser for CMAP data for pr (#3766) Adding pr, tauu, tauv, tos to NCEP2 CMORISer (#3765) Readthedocs configuration/builds: revert to miniconda before miniforge is available (#3785) Adapt ESMValTool to new configuration (#3761) Adding pr, tauu, tauv NOAA-CIRES-20CR-V2 CMORISER (#3763) update comment in conda lock creation Github action (#3788) [Condalock] Update Linux condalock file (#3786) update Docker builds badge in README (#3783) Pin mamba<2 for conda-lock: solution by Ben Mares @maresb (#3771) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script
To help with the number of pull requests: