Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip all ATS tests since OpenID is getting retired #105

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

valeriupredoi
Copy link
Collaborator

@valeriupredoi valeriupredoi commented Jul 4, 2024

CI Tests started failing again because the OpenID service at DKRZ has been retired.

@valeriupredoi
Copy link
Collaborator Author

OK yet another barf since there is no more CMIP5 on DKRZ arghhh

@valeriupredoi
Copy link
Collaborator Author

OK so the 500-503s are transitory - why them ESGF nodes so flaky at connecting to all of a sudden? I don't remember them being so fragile? @bouweandela what do you say we got us rid of Pythons 3.8 and 3.9, at least only in the CI?

@bouweandela
Copy link
Collaborator

bouweandela commented Aug 12, 2024

The OpenID servers that used to be provided by ESGF will stop operating and a new authentication mechanism will be set up in the future. How about unconditionally skipping all of the tests in tests/test_ats.py for now? We can see about removing support for authentication completely from the package in the future. Currently, it is not necessary to log in to access any data on ESGF anyway.

@valeriupredoi
Copy link
Collaborator Author

The OpenID servers that used to be provided by ESGF will stop operating and a new authentication mechanism will be set up in the future. How about unconditionally skipping all of the tests in tests/test_ats.py for now? We can see about removing support for authentication completely from the package in the future. Currently, it is not necessary to log in to access any data on ESGF anyway.

cheers, bud! My thought exactly when I started reading on OpenID changes - lemme do that here 👍

@valeriupredoi valeriupredoi changed the title skip the last ATS test since that is not openid skip all ATS tests since OpenID is getting retired Aug 14, 2024
tests/test_context.py Outdated Show resolved Hide resolved
@valeriupredoi
Copy link
Collaborator Author

@bouweandela shall we get this in, buds? 🍺

@bouweandela
Copy link
Collaborator

Yes. Could you please update the pull request description so it reflects what is in the pull request?

Co-authored-by: Bouwe Andela <[email protected]>
@valeriupredoi
Copy link
Collaborator Author

ah true that - done, good point!

@bouweandela bouweandela merged commit d14e6f8 into master Aug 26, 2024
5 checks passed
@bouweandela bouweandela deleted the skip_test_openid branch August 26, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants