Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🟨 — Refactor Query and ShazamQuery component #57

Closed
Dysta opened this issue Mar 27, 2022 · 0 comments · Fixed by #71
Closed

🟨 — Refactor Query and ShazamQuery component #57

Dysta opened this issue Mar 27, 2022 · 0 comments · Fixed by #71
Assignees
Labels
enhancement New feature or request
Projects

Comments

@Dysta
Copy link
Owner

Dysta commented Mar 27, 2022

Description

The two *Query components are starting to be difficult to maintain and improve. The lack of testing makes it hard to check if an update doesn't break all the old features. Moreover, it is complicated to add pre/post processing because of the bad design of the component.

Expected result

A Query base class allowing you to do pre or post processing simply. Tests.

Actual result

Nothing good for the long term

Reproduction Steps

Other (screen)

@Dysta Dysta added the unconfirmed This doesn't seem right label Mar 27, 2022
@Dysta Dysta self-assigned this Mar 27, 2022
@Dysta Dysta added this to To do in RoadMap via automation Mar 27, 2022
@Dysta Dysta mentioned this issue May 1, 2023
6 tasks
@Dysta Dysta moved this from To do to In progress in RoadMap May 1, 2023
@Dysta Dysta linked a pull request May 1, 2023 that will close this issue
6 tasks
@Dysta Dysta added enhancement New feature or request and removed unconfirmed This doesn't seem right labels May 10, 2023
@Dysta Dysta closed this as completed in #71 May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
RoadMap
In progress
Development

Successfully merging a pull request may close this issue.

1 participant