Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods count.disk.frame() and tally.disk.frame() #318

Open
romainfrancois opened this issue Dec 7, 2020 · 2 comments
Open

Methods count.disk.frame() and tally.disk.frame() #318

romainfrancois opened this issue Dec 7, 2020 · 2 comments

Comments

@romainfrancois
Copy link
Contributor

In dplyr 1.0.3 to be released soon, we have made count() and tally() generic, and this seems to be a problem for disk.frame. Our reverse dependency checks raise:

# disk.frame

<details>

* Version: 0.3.7
* GitHub: https://github.com/xiaodaigh/disk.frame
* Source code: https://github.com/cran/disk.frame
* Date/Publication: 2020-07-07 13:10:03 UTC
* Number of recursive dependencies: 110

Run `cloud_details(, "disk.frame")` for more info

</details>

## Newly broken

*   checking S3 generic/method consistency ... WARNING
    ```
    count:
      function(x, ..., wt, sort, name)
    count.disk.frame:
      function(.data, ...)
    
    tally:
      function(x, wt, sort, name)
    tally.disk.frame:
      function(.data, ...)
    
    See section ‘Generic functions and methods’ in the ‘Writing R
    Extensions’ manual.
    
    Found the following apparent S3 methods exported but not registered:
      count.disk.frame tally.disk.frame
    See section ‘Registering S3 methods’ in the ‘Writing R Extensions’
    manual.
    ```

*   checking Rd \usage sections ... NOTE
    ```
    S3 methods shown with full name in documentation object 'select.disk.frame':
      ‘tally.disk.frame’ ‘count.disk.frame’
    
    The \usage entries for S3 methods should use the \method markup and not
    their full name.
    See chapter ‘Writing R documentation files’ in the ‘Writing R
    Extensions’ manual.
    ```

I understand these methods are created by create_chunk_mapper(), perhaps this could also use the same formals ?

@xiaodaigh
Copy link
Collaborator

I will ready a branch when dplyr 1.0.3 is released. Not sure which will come sooner, release of dplyr 1.0.3 or a new NSE method for disk.frame.

@xiaodaigh
Copy link
Collaborator

actually to implement them properly is quite tough. So I have removed them for now. They are convenience methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants