-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Faker class constructor with FakeValuesService as argument #402
Comments
Sorry I don't quite follow what you're trying to do, could you please supply some code to illustrate your point? |
|
@kitherill can't you just create a wrapper class like |
I've added a branch for this feature called |
Maybe we should close this issue, @egoetschalckx 's PR has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For my current task I need both Faker class and 'lower level' FakeValuesService (in order to access values nation.yml). FakeValueService initialised in Faker class is package-visible, so I have to create another instance of FakeValueService, while ideally I would want to pass predefined FakeValueService instance to Faker so that it is reused.
The text was updated successfully, but these errors were encountered: