Fix compiler div-by-0 error when it encountered 1.0/0.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with division by 0. Tricked the compiler to use volatile local variable zero instead, so it does not know for sure whether or not it's going to be zero.
|
Then how does test the NaN case? The division by 0 was specifically done to test handling NaN case. |
|
Sorry, That need to think..., but the "1.0/0.0" is incorrect when compiler it. |
|
that's why I used a volatile variable zero to trick the compiler to do it anyway. My patch compiles |
|
ok |
|
Nice patch. Thanks! :) |
|
Thanks Dave! |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tricked the compiler to use volatile local variable zero instead, so it does not know for sure whether or not it's going to be zero.
Sorry, I have my editor to remove all trailing whitespaces automatically, so it has those fixed too.