Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes in 2.0.0 #60

Open
4 of 11 tasks
FSMaxB opened this issue Nov 12, 2016 · 5 comments
Open
4 of 11 tasks

Breaking changes in 2.0.0 #60

FSMaxB opened this issue Nov 12, 2016 · 5 comments
Milestone

Comments

@FSMaxB
Copy link
Collaborator

FSMaxB commented Nov 12, 2016

With 2.0.0 let's try to get things right with the following breaking changes:

@FSMaxB FSMaxB added this to the 1.0.0 milestone Nov 12, 2016
@FSMaxB
Copy link
Collaborator Author

FSMaxB commented Nov 12, 2016

I just found a problem with size_t: C89 doesn't specify the constant SIZE_MAX. So my little macro trick (see #27) doesn't work with size_t. I will have to rethink that. #62

@DaveGamble
Copy link
Owner

@FSMaxB just to clarify:

Version 1.0.0 should be: 3a7bd69
(possibly plus a few small fixes, which I'm happy to branch out and apply).

Your new release, which requires code changes, should be 2.0.0. You're welcome to make it a separate project, but until it's tested, working, and everything is done, head MUST point to that commit.

@FSMaxB
Copy link
Collaborator Author

FSMaxB commented Nov 13, 2016

Understood. I will release 1.0.0 with the build system improvements ( but without the breaking changes. That includes the library version.

@FSMaxB FSMaxB changed the title Breaking changes in 1.0.0 Breaking changes in 2.0.0 Nov 13, 2016
@DaveGamble
Copy link
Owner

You are AWESOME. Thanks :)

@FSMaxB
Copy link
Collaborator Author

FSMaxB commented Feb 16, 2017

It might be useful to return an error position instead of an error pointer. That would help to prevent pointers to invalid memory (in case the input string gets freed, but the error pointer is still around).

If a user of the library wants the old error pointer the user would just add the error position to the beginning of the json string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants