Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize on layout changes due to width changes #543

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Resize on layout changes due to width changes #543

merged 1 commit into from
Aug 16, 2022

Conversation

JMolenkamp
Copy link
Contributor

Currently, resizing only happens based on height changes. However, the layout of surrounding elements may change due to width changes, which also requires resizing:

image

image

@AllanJard
Copy link
Contributor

Just to confirm my understanding here - are you saying that when you resize horizontally the height of the rows will change? I can see how that would effect the number of rows that should be displayed, but that isn't shown in your screenshots, so I'm wondering if I've got the wrong end of the stick.

@JMolenkamp
Copy link
Contributor Author

No, what i meant is that due to width changes, the layout of surrounding elements might change, which in turn changes the available height for the rows. In the second screenshot, the layout for the info and pagination elements has changed, which leaves less space for the rows. Currently, the plugin only acts based on height changes, but in this case it requires acting based on width changes to keep the entire table in view.

@AllanJard
Copy link
Contributor

I'm with you now - thanks! It looks like there might be conflicts with your other change. Might you be able to rebase and update to get a clean merge?

@JMolenkamp
Copy link
Contributor Author

Yeah, sure. I will be on vacation the coming week, after that i will fix the PR.

@JMolenkamp
Copy link
Contributor Author

The PR has been updated

@AllanJard AllanJard merged commit 6315d1a into DataTables:master Aug 16, 2022
@AllanJard
Copy link
Contributor

Super - many thanks!

@JMolenkamp JMolenkamp deleted the page-resize branch August 16, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants