Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the way to specify the topic on channel creating. #421

Merged
merged 4 commits into from
Apr 24, 2019

Conversation

Kiritsu
Copy link
Contributor

@Kiritsu Kiritsu commented Apr 24, 2019

Summary

Currently, we can't create a channel and specify its topic directly, we have to call ModifyAsync.
As seen here: https://discordapp.com/developers/docs/resources/guild#create-guild-channel we can specify the topic in the request payload.

Details

Simply added the topic in different channel creation method
Added the topic property in the request payload

Copy link
Contributor

@Emzi0767 Emzi0767 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

DSharpPlus/Net/Abstractions/RestChannelPayloads.cs Outdated Show resolved Hide resolved
DSharpPlus/Net/DiscordApiClient.cs Outdated Show resolved Hide resolved
DSharpPlus/Entities/DiscordGuild.cs Outdated Show resolved Hide resolved
DSharpPlus/Entities/DiscordGuild.cs Outdated Show resolved Hide resolved
DSharpPlus/Entities/DiscordGuild.cs Outdated Show resolved Hide resolved
DSharpPlus/Entities/DiscordGuild.cs Outdated Show resolved Hide resolved
DSharpPlus.Rest/DiscordRestClient.cs Outdated Show resolved Hide resolved
@Emzi0767 Emzi0767 merged commit fbe8212 into DSharpPlus:master Apr 24, 2019
@Emzi0767 Emzi0767 added the v4.x label Mar 24, 2020
OoLunar pushed a commit that referenced this pull request Oct 3, 2024
* Adds the way to specify the topic on channel creating.

* Forgot to update the rest client.

* Use Optional<string> instead of string for the topic.

* Use Optional<string> for topic on the channel modify payload and edit model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants