Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Name starts with "<" then the mail address is partially displayed #106

Open
ghost opened this issue Oct 23, 2018 · 4 comments
Open

If Name starts with "<" then the mail address is partially displayed #106

ghost opened this issue Oct 23, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 23, 2018

Here https://forum.dlang.org/post/[email protected]. The user name used was
<Lesser_name and the user address used was [email protected] But something strange is displayed instead of <Lesser_name there's Lesser_name <address

@CyberShadow
Copy link
Owner

From: <lesser_name <[email protected]>

That doesn't look valid. The server shouldn't have accepted it.

@CyberShadow
Copy link
Owner

https://tools.ietf.org/tools/msglint/ says:

ERROR: at least one mailbox required at or before token '<' in header 'From' 
       at line 2
ERROR: unexpected tokens at end of header 'From' at line 2
ERROR:  Token type       special: <
ERROR:  Token type          atom: address
ERROR:  Token type       special: @
ERROR:  Token type          atom: somewhere
ERROR:  Token type       special: .
ERROR:  Token type          atom: org
ERROR:  Token type       special: >

@CyberShadow
Copy link
Owner

We can fix DFeed from emitting such messages, but we can't fix others sending such malformed messages via email/NNTP..

@CyberShadow
Copy link
Owner

DFeed's header parsing is really ad-hoc and needs a rewrite. I'll have to get back to this later, probably port the test messages from my Windows installation's hard drive to real unit tests first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant