Optimisation codes #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIYgod
requested changes
Oct 16, 2022
|
Changes to the key will invalidate SSR - because the key needs to be the same on both the client and the server. I've reverted back in 4475ffe |
I'm so sorry to hear that. It will invalid SSR, if i have some time i will re work on it. If i under standard the logic of code, we try to read the data in the cache, if data doesn't exist, we save the data in the cache. the data is the input data. |
zsakvo
pushed a commit
to zsakvo/xLog
that referenced
this pull request
Apr 9, 2023
zsakvo
pushed a commit
to zsakvo/xLog
that referenced
this pull request
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I read the code source and i fixed some warning message when compile the project.
Then i checked quickly the redis and i think we can do it better :)
To serialize some data in key is not a good idea, actually some shot data will be serialized in the KEY and in the VALUE.
JSON.stringifywill be called twice in the getCache function. With the user growth, the KEY may be long than 1kb (if the object is large enough)Before:
After:
Cordialement,
qfdk