Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 默认显示home,如果配置navigation 以navigation 为主 #26

Merged
merged 2 commits into from
Oct 12, 2022
Merged

fix: 默认显示home,如果配置navigation 以navigation 为主 #26

merged 2 commits into from
Oct 12, 2022

Conversation

qfdk
Copy link
Contributor

@qfdk qfdk commented Oct 12, 2022

  • 默认显示 Home 按钮，路径为 /
  • 如果配置navigation 以navigation 配置为主

@DIYgod
Copy link
Member

DIYgod commented Oct 12, 2022

Thanks for the pr, but what I prefer is to add Home at the top if the path / is not configured, so as not to affect the existing site. It also means that users can override Home with custom text instead of removing Home totally.

@qfdk
Update SiteHeader.tsx
b0d5840 
fix: change the display "Home" logic when url path === "/", t will not to affect the existing site
@qfdk
Copy link
Contributor Author

qfdk commented Oct 12, 2022

@DIYgod Quick fix, need test the logic ..

@DIYgod DIYgod merged commit 170034e into Crossbell-Box:dev Oct 12, 2022
@DIYgod
Copy link
Member

DIYgod commented Oct 12, 2022

Merged, thanks so much!

zsakvo pushed a commit to zsakvo/xLog that referenced this pull request Apr 9, 2023
@DIYgod
Merge pull request Crossbell-Box#26 from qfdk/dev
854ea1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DIYgod DIYgod DIYgod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qfdk @DIYgod