Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a sidebar is the parent, the child can not be made full screen with height 100% #261

Open
mme opened this issue Mar 13, 2024 · 1 comment · May be fixed by #565
Open

When a sidebar is the parent, the child can not be made full screen with height 100% #261

mme opened this issue Mar 13, 2024 · 1 comment · May be fixed by #565
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mme
Copy link
Collaborator

mme commented Mar 13, 2024 •
edited
Loading

Problem:
When putting child nodes under CopilotSidebar, these nodes can't be made height: 100% easily because of the way the DOM node are generated.

Proposed Solution:
In CopilotSidebar, change the parent DOM nodes so that the child elements can be set to height: 100%.
@mme mme added bug Something isn't working good first issue Good for newcomers labels Mar 13, 2024
@Souradip121
Copy link

I would definitely love to work on this issue. Is it possible @mme to assign me to this???

suhasdeshpande added a commit to suhasdeshpande/CopilotKit that referenced this issue Sep 11, 2024
@suhasdeshpande
Fix: Adjust modal height to prevent fullscreen issues in sidebar
0bf7bdb 
- Remove fixed height style from modal container
- Allow modal to adapt to parent container dimensions
- Addresses issue CopilotKit#261 where sidebar parent prevented fullscreen child
@suhasdeshpande suhasdeshpande linked a pull request Sep 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Adjust modal height to prevent fullscreen issues in sidebar suhasdeshpande/CopilotKit
2 participants
@mme @Souradip121