Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepency in line counting #889

Closed
letypequividelespoubelles opened this issue Jul 28, 2024 · 2 comments
Closed

Discrepency in line counting #889

letypequividelespoubelles opened this issue Jul 28, 2024 · 2 comments
Assignees

Comments

@letypequividelespoubelles
Copy link
Collaborator

Issue arising thanks to @gusiri :

https://docs.google.com/spreadsheets/d/1Qtmt_KyUrkyB-GC1z5RuRYbm0T2_C8nVtqLT-BJO5IQ/edit?usp=sharing

Note: this is a conflation of a single block, so theoretically, the only difference should be for WCP module.

Small (ie < 10) could come from spillings.

@letypequividelespoubelles
Copy link
Collaborator Author

@gusiri Is it still relevant ?

@gusiri
Copy link
Contributor

gusiri commented Sep 20, 2024

It turns out that a conflation generated by replay() has this issue. We don't have this issue with a conflation generated by linea_generateConflatedTracesToFileV2. replay() drops some transactions for various reasons, and these are being addressed by other issues.

@letypequividelespoubelles letypequividelespoubelles closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants