-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can (and should?) we get PC_NEW from Besu ? #882
Comments
Seems like the right option. I don't see any case where it wouldn't call Precompiles don't seem to use PC which makes sense. |
We currently hand compute PC_NEW. In Besu the program counter (and gas) are updated before calling
tracePostExecution
hook.HowevertracePostExecution
isn't called at all ifoperationResult == null
.It seems there are 3 possibilities if we want to grab the updated program counter:
tracePostExecution
regardless ofoperationResult
which may be undesirable for BesutracePostExecutionForLinea
that triggers before theoperationResult == null
checkNote: we may require the naïve value of PC_NEW in all cases, exceptional or not, except for when the underlying opcode is a JUMP(I) in which case it's more complex.
The text was updated successfully, but these errors were encountered: