Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MustSetRandom methods #505

Open
ivokub opened this issue May 23, 2024 · 0 comments
Open

feat: add MustSetRandom methods #505

ivokub opened this issue May 23, 2024 · 0 comments
Assignees
Labels
consolidate strengthen an existing feature

Comments

@ivokub
Copy link
Collaborator

ivokub commented May 23, 2024

In interfaces/implementations which randomize the values with crypto/rand.Reader, we should handle the errors. By default it never errors on Linux, but may on other platforms. I guess having alternative methods Must... which either randomize values or panic, could work.

With that, it would be beneficial to check all downstream usage of SetRandom methods in gnark/gnark-crypto and change accordingly.

@ivokub ivokub added the consolidate strengthen an existing feature label May 23, 2024
@ivokub ivokub self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consolidate strengthen an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant