Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docu: Merkle tree documentation outdated or hashing of nodes in is incorrect #482

Open
Engeloid opened this issue Jan 30, 2024 · 0 comments
Open

Docu: Merkle tree documentation outdated or hashing of nodes in is incorrect #482

Engeloid opened this issue Jan 30, 2024 · 0 comments

Comments

@Engeloid
Copy link

As seen in the in-line comments below, nodes are supposed to be hashed with 0x01 but they are not. I just wanted to clear things up, as I had trouble thinking they were hashed as seen in the comment.

gnark-crypto/accumulator/merkletree/tree.go

Line 101 in 2e4aaaa

// Hash(0x01 || left sibling sum || right sibling sum)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Engeloid