Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to binrw 0.12 #30

Merged
merged 1 commit into from
Oct 4, 2023
Merged

deps: update to binrw 0.12 #30

merged 1 commit into from
Oct 4, 2023

Conversation

poliorcetics
Copy link
Contributor

This updates the MSRV to 1.66, that's maybe too big a leap ?

ColinFinck
ColinFinck reviewed Sep 30, 2023
View reviewed changes
Copy link
Owner

@ColinFinck ColinFinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposed to dependency upgrades, even if they increase the MSRV.
But looking at binrw 0.12, I fail to see:

  • Where does it change MSRV to 1.66? I see such a change for master, but not for the 0.12.0 release.
  • What has actually changed between 0.11 and 0.12? I don't find the usual CHANGELOG.md.
  • Is there a specific reason why you need binrw 0.12 instead of 0.11?

CC @jam1garner

@poliorcetics
Copy link
Contributor Author

Where does it change MSRV to 1.66? I see such a change for master, but not for the 0.12.0 release.

Ah I think I checked master and not 0.12, my bad

What has actually changed between 0.11 and 0.12? I don't find the usual CHANGELOG.md.

https://github.com/jam1garner/binrw/releases/tag/v0.12.0

Is there a specific reason why you need binrw 0.12 instead of 0.11?

Just keeping up to date with dependencies and trying to reduces projects' trees to a single instance of each, to avoid compiling almost the same code several times. It also has the benefit that if a type from a dependency is exposed in the public API, it's the same everywhere (because crateA::MyType, v0.3.0 and crateA::MyType, v0.4.0 are incompatible)

@ColinFinck
Copy link
Owner

Where does it change MSRV to 1.66? I see such a change for master, but not for the 0.12.0 release.

Ah I think I checked master and not 0.12, my bad

Alright. Can you change the MSRV to the right Rust version for binrw 0.12 then?

@poliorcetics
Copy link
Contributor Author

I forgot I had changed it in the manifest, done

@ColinFinck ColinFinck merged commit cf4c127 into ColinFinck:master Oct 4, 2023
1 check passed
@poliorcetics poliorcetics deleted the binrw-update branch October 4, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColinFinck ColinFinck ColinFinck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poliorcetics @ColinFinck