Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Windows entrypoint (codecept.bat) #5265

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Correct Windows entrypoint (codecept.bat) #5265

merged 1 commit into from
Dec 4, 2018

Conversation

sergeyklay
Copy link
Contributor

@sergeyklay sergeyklay commented Nov 13, 2018 •
edited
Loading

I simplified the codecept.bat file and removed @var_name@ variables. The @var_name@ vars should be replaced during a PHAR build. I think that @var_name@ vars are not universal, and I am also not sure that they make sense (or even used) right now.

It's using %PHP_PEAR_PHP_BIN% because that's a global variable which may be set by PEAR. I just figure, if it's available anyway, why not use it; and in the other case, it will just try php, assuming most Windows users will have added that to their PATH.

These changes should be covered by appveyor.yml:test_script (I hope).

@sergeyklay
Copy link
Contributor Author

Tests was failed on AppVeyor. This is unrelated

@sergeyklay sergeyklay closed this Nov 13, 2018
@sergeyklay sergeyklay reopened this Nov 13, 2018
@sergeyklay
Copy link
Contributor Author

Failures

  • kb2999226 (exited 1058) - Error while running 'C:\ProgramData\chocolatey\lib\KB2999226\tools\chocolateyinstall.ps1'.
  • kb2919442 (exited 1058) - Error while running 'C:\ProgramData\chocolatey\lib\KB2919442\tools\ChocolateyInstall.ps1'.
  • kb3035131 (exited 1058) - Error while running 'C:\ProgramData\chocolatey\lib\KB3035131\Tools\ChocolateyInstall.ps1'.
ERROR: Update KB3035131 installation failed (exit code 1058).
The install of kb3035131 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\KB3035131\Tools\ChocolateyInstall.ps1'.
 See log for details.

ERROR: Running ["C:\windows\System32\wusa.exe" "C:\Users\appveyor\AppData\Local\Temp\1\chocolatey\KB2919442\1.0.20160915\Windows8.1-KB2919442-x64.msu" /quiet /norestart /log:"C:\Users\appveyor\AppData\Local\Temp\1\chocolatey\KB2919442.Install.evt" ] was not successful. Exit code was '1058'. See log for possible error messages.
The install of kb2919442 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\KB2919442\tools\ChocolateyInstall.ps1'.
 See log for details.

WARNING: Update KB2999226 installation failed (exit code 1058).
WARNING: More details may be found in the installation log (C:\Users\appveyor\AppData\Local\Temp\1\chocolatey\KB2999226.Install.evt) or the system CBS log (C:\windows\Logs\CBS\CBS.log).
ERROR: Update KB2999226 installation failed (exit code 1058).
The install of kb2999226 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\KB2999226\tools\chocolateyinstall.ps1'.
 See log for details.

@sergeyklay
Copy link
Contributor Author

Okay, I've found what was causing OpenSSL.Light package installation to fail. Changed Windows update service start type.

@sergeyklay sergeyklay requested a review from DavertMik November 13, 2018 07:58
@sergeyklay sergeyklay mentioned this pull request Nov 17, 2018
Merged
@DavertMik
Copy link
Member

Looks good to me

@sergeyklay sergeyklay mentioned this pull request Nov 21, 2018
Merged
@DavertMik
Copy link
Member

I think we no longer use .bat but let's keep that patch :)

@DavertMik DavertMik merged commit 5454fe1 into Codeception:2.5 Dec 4, 2018
@sergeyklay sergeyklay deleted the fix/correct-windows-entrypoint branch December 4, 2018 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik Awaiting requested review from DavertMik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyklay @DavertMik