[WIP] Start using assert() and not fail() #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Jul 8, 2018
src/Codeception/Module/Laravel5.php
Outdated
| if ($currentNum != $expectedNum) { | ||
| $this->fail("The number of found $table ($currentNum) does not match expected number $expectedNum with " . json_encode($attributes)); | ||
| } | ||
| $this->assertEquals($expectedNum, $currentNum, |
There was a problem hiding this comment.
- Opening parenthesis of a multi-line function call must be the last content on the line
- Only one argument is allowed per line in a multi-line function call
Nitpick-CI
reviewed
Jul 8, 2018
src/Codeception/Module/Laravel5.php
Outdated
| $this->fail("The number of found $table ($currentNum) does not match expected number $expectedNum with " . json_encode($attributes)); | ||
| } | ||
| $this->assertEquals($expectedNum, $currentNum, | ||
| "The number of found $table ($currentNum) does not match expected number $expectedNum with " . json_encode($attributes)); |
There was a problem hiding this comment.
- Multi-line function call not indented correctly; expected 12 spaces but found 16
- Closing parenthesis of a multi-line function call must be on a line by itself
Nitpick-CI
reviewed
Jul 8, 2018
src/Codeception/Module/Laravel5.php
Outdated
| if ($currentNum != $expectedNum) { | ||
| $this->fail("The number of found records ($currentNum) does not match expected number $expectedNum in table $table with " . json_encode($attributes)); | ||
| } | ||
| $this->assertEquals($expectedNum, $currentNum, |
There was a problem hiding this comment.
- Opening parenthesis of a multi-line function call must be the last content on the line
- Only one argument is allowed per line in a multi-line function call
Nitpick-CI
reviewed
Jul 8, 2018
src/Codeception/Module/Laravel5.php
Outdated
| $this->fail("The number of found records ($currentNum) does not match expected number $expectedNum in table $table with " . json_encode($attributes)); | ||
| } | ||
| $this->assertEquals($expectedNum, $currentNum, | ||
| "The number of found records ($currentNum) does not match expected number $expectedNum in table $table with " . json_encode($attributes)); |
There was a problem hiding this comment.
- Multi-line function call not indented correctly; expected 12 spaces but found 16
- Closing parenthesis of a multi-line function call must be on a line by itself
|
Thanks |
|
haha, this PR was "work in progress".. i would have added additional asserts.. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Laravel5module in order to useassert()rather thanfail()to indicate if something worked / did not work..Note that this PR is "work in progress"..