Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shim.php #5013

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Update shim.php #5013

merged 1 commit into from
Jun 20, 2018

Conversation

josephzidell
Copy link
Contributor

Fix indentation [skip ci]

@josephzidell
Update shim.php
d50ad4b 
Fix indentation [skip ci]
@ddinchev
Copy link
Contributor

ddinchev commented Jun 18, 2018 •
edited
Loading

Imho if we are going to modify indentations, these should be imposed and checked by some coding standards tool like CodeSniffer. Otherwise it's a matter of opinion.

@josephzidell
Copy link
Contributor Author

I agree

@DavertMik
Copy link
Member

Yeah, shim.php outstands from our main code base so we don't have any strict policy about it's code.
But thanks for improving it.

@DavertMik DavertMik merged commit 534dc68 into Codeception:2.4 Jun 20, 2018
@josephzidell josephzidell deleted the patch-3 branch June 21, 2018 06:58
@josephzidell
Copy link
Contributor Author

Thanks @DavertMik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephzidell @ddinchev @DavertMik